1154532 - Add ThrowRangeError and ThrowTypeError self-hosting intrinsics

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[Jeff Walden [:Waldo]]

My %TypedArray%.prototype.set patch had a bug in it where I used ThrowError with an error message for an Error, when the spec required a RangeError be thrown.  This was totally non-obvious without going out of my way to consult js.msg.  Add self-hosting intrinsics like ThrowTypeError, with the exact same behavior as ThrowError now but asserting the error number's type is the expected one, to make clear at call sites what's happening, with assertions to verify it.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Patch

I added the intrinsics, and I added a smattering of uses to demonstrate the intrinsics work.  But there's still a lot of work remaining to convert all ThrowError uses to a more-specific thing.

Interestingly, the spec appears to have *no* cases where Error is thrown.  And our self-hosted code appears not to have any places where ReferenceError, SyntaxError, or URIError are thrown.  So no adding corresponding intrinsics yet.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8592549 [details] [diff] [review]
Patch

Review of attachment 8592549 [details] [diff] [review]:
-----------------------------------------------------------------

Particularly nice.

::: js/src/vm/SelfHosting.cpp
@@ +154,5 @@
>                                JSITER_OWNONLY | JSITER_HIDDEN | JSITER_SYMBOLS);
>  }
>  
> +static void
> +ThrowParticularError(JSContext* cx, JSExnType type, const CallArgs& args)

"ThrowErrorWithType", perhaps? "Particular" doesn't seem particularly descriptive in this particular use.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76326ec30cd6

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/76326ec30cd6