1154547 - Make a couple of small improvements to about:serviceworkers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Part 1: Linkify the worker script URLs in about:serviceworkers

Comment 2

[(no longer active)]

Attachment: Part 2: Make it possible to update a service worker from about:serviceworkers

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8592570 [details] [diff] [review]
Part 1: Linkify the worker script URLs in about:serviceworkers

Review of attachment 8592570 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutServiceWorkers.js
@@ +81,5 @@
>      item.appendChild(bold);
>  
> +    if (makeLink) {
> +      let link = document.createElement("a");
> +      link.href = value;

link.title = "this would be nice to have";
link._target too.

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8592571 [details] [diff] [review]
Part 2: Make it possible to update a service worker from about:serviceworkers

Review of attachment 8592571 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutServiceWorkers.js
@@ +100,5 @@
>  
> +  var updateButton = document.createElement("button");
> +  updateButton.appendChild(document.createTextNode(bundle.GetStringFromName('update')));
> +  updateButton.onclick = function() {
> +    gSWM.update(info.scope);

would be super cool if update returns a promise so that we can show a loading icon and stop it when the operation is fully completed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/693f73c613d0
https://hg.mozilla.org/mozilla-central/rev/21a2d0003caa

Comment 6

[Francesco Lodolo [:flod]]

Request for the future: if a word in English is unclear, you should add a localization comment.

Example: is "Update" a verb or a noun? In this case it's a button label, so a verb, but people don't have access to bugs and code, just to a text file saying "Update".

Comment 7

[(no longer active)]

Yep, noted.  Thanks, flod!