[Flame][Task Manager] User can switch recent apps in the background in confirm install app view after pressing power button

NEW
Unassigned

Status

Firefox OS
Gaia::System::Window Mgmt
3 years ago
3 years ago

People

(Reporter: Hermes Cheng (inactive after July 27, 2015), Unassigned, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe][lang=js])

+++ This bug was initially created as a clone of Bug #1144054 +++

[1.Description]:
User can switch between recent apps in the background in comfirm install app view if use has pressed the power button.

[2.Testing Steps]: 
1.Run some apps in the background.
2.Connect the network and launch Marketplace.
3.Select an app to download.
4.After install dialog is prompted, press the power button.
5.Press the power button and unlock the phone
6.Slide from left/ right edge to right/ left.

[3.Expected Result]: 
At step 6, user cannot switch recent apps in the background.

[4.Actual Result]:
At step 6, you can switch recent apps in the background.

[5.Reproduction Frequency]: 
Always Recurrence,10/10
*test env:

*2.2
Build ID               20150414162502
Gaia Revision          16e948bfaaa15dbc0200135d52f16257b4eab193
Gaia Date              2015-04-14 21:08:25
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0eec28e78eb1
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.201515
Firmware Date          Tue Apr 14 20:15:24 EDT 2015
Bootloader             L1TC000118D0

*master
Build ID               20150414160204
Gaia Revision          8e28588496f82f8f069c171c65842d622b9d8d7d
Gaia Date              2015-04-14 18:43:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/de27ac2ab94f
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150414.194002
Firmware Date          Tue Apr 14 19:40:12 EDT 2015
Bootloader             L1TC000118D0
Summary: [Flame][Task Manager] User can switch recent apps in the background in confirm install app view. → [Flame][Task Manager] User can switch recent apps in the background in confirm install app view after pressing power button
Etienne, could you take a look?
Flags: needinfo?(etienne)
This is an interesting one.
In short: we need to address this comment [1].

Currently the app install dialogs [2] are not true SystemDialogs [3], so they're not part of Hierarchy Management [4].

Making them system dialogs will get us the EdgeSwipeDetector suspend/resume "for free", because of [5].
For inspiration on how to make new SystemDialogs, take a look at this simple one [6].

[1] https://github.com/mozilla-b2g/gaia/blob/27fe0f4261e3685187769411f2f74cff19287b19/apps/system/js/edge_swipe_detector.js#L172-173
[2] https://github.com/mozilla-b2g/gaia/blob/27fe0f4261e3685187769411f2f74cff19287b19/apps/system/js/app_install_manager.js#L35-62
[3] https://github.com/mozilla-b2g/gaia/blob/27fe0f4261e3685187769411f2f74cff19287b19/apps/system/js/system_dialog.js#L6-31
[4] https://github.com/mozilla-b2g/gaia/blob/27fe0f4261e3685187769411f2f74cff19287b19/apps/system/js/hierarchy_manager.js#L62-73
[5] https://github.com/mozilla-b2g/gaia/blob/27fe0f4261e3685187769411f2f74cff19287b19/apps/system/js/edge_swipe_detector.js#L103-119
[6] https://github.com/mozilla-b2g/gaia/blob/27fe0f4261e3685187769411f2f74cff19287b19/apps/system/js/system_nfc_connect_dialog.js#L13-14
Mentor: etienne@segonzac.info
Flags: needinfo?(etienne)
Whiteboard: [systemsfe] → [systemsfe][lang=js]
You need to log in before you can comment on or make changes to this bug.