Closed Bug 1154599 Opened 5 years ago Closed 5 years ago

Revert unintentional change to crash reporting infra from bug 1071360

Categories

(Firefox Build System :: General, defect)

39 Branch
x86_64
Windows 8.1
defect
Not set

Tracking

(firefox38 fixed, firefox39 fixed, firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: rkent, Assigned: bent.mozilla)

Details

Attachments

(1 file)

Bug 107160 caused an unintentional change in crash reporting infra, which was reverted in mozilla-central in 0253a852074f  But the offending patch also landed in mozilla-beta and mozilla-central, and results in a test failure in Thunderbird builds for comm-aurora and comm-beta (which will become the esr release). Surely this is also not wanted in FF either?

transport mozilla-central changeset 0253a852074f to mozilla-aurora and mozilla-beta.

Ben, can you comment since you did the fix for mozilla-central?
Flags: needinfo?(bent.mozilla)
(In reply to Kent James (:rkent) from comment #0)
> But the offending patch
> also landed in mozilla-beta and mozilla-central,

that should be "and mozilla-aurora"
0253a852074f should be uplifted everywhere ce2692d64bcf was, right. I'm surprised it causes a test failure though...
Flags: needinfo?(bent.mozilla)
Sorry about that!
Attached patch RevertSplinter Review
Approval Request Comment
[Feature/regressing bug #]: 1071360
[User impact if declined]: Infra problems
[Describe test coverage new/current, TreeHerder]: Does not affect the build
[Risks and why]: Unintentional change was accidentally uplifted to aurora/beta.
[String/UUID change made/needed]: None
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #8592883 - Flags: review+
Attachment #8592883 - Flags: approval-mozilla-beta?
Attachment #8592883 - Flags: approval-mozilla-aurora?
Comment on attachment 8592883 [details] [diff] [review]
Revert

should be in 38 beta 5
Attachment #8592883 - Flags: approval-mozilla-beta?
Attachment #8592883 - Flags: approval-mozilla-beta+
Attachment #8592883 - Flags: approval-mozilla-aurora?
Attachment #8592883 - Flags: approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.