1154599 - Revert unintentional change to crash reporting infra from bug 1071360

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Kent James (:rkent)]

Bug 107160 caused an unintentional change in crash reporting infra, which was reverted in mozilla-central in 0253a852074f  But the offending patch also landed in mozilla-beta and mozilla-central, and results in a test failure in Thunderbird builds for comm-aurora and comm-beta (which will become the esr release). Surely this is also not wanted in FF either?

transport mozilla-central changeset 0253a852074f to mozilla-aurora and mozilla-beta.

Ben, can you comment since you did the fix for mozilla-central?

Comment 1

[Kent James (:rkent)]

(In reply to Kent James (:rkent) from comment #0)
> But the offending patch
> also landed in mozilla-beta and mozilla-central,

that should be "and mozilla-aurora"

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

0253a852074f should be uplifted everywhere ce2692d64bcf was, right. I'm surprised it causes a test failure though...

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Sorry about that!

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Revert

Approval Request Comment
[Feature/regressing bug #]: 1071360
[User impact if declined]: Infra problems
[Describe test coverage new/current, TreeHerder]: Does not affect the build
[Risks and why]: Unintentional change was accidentally uplifted to aurora/beta.
[String/UUID change made/needed]: None

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8592883 [details] [diff] [review]
Revert

should be in 38 beta 5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7b296a71b115

Comment 7

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-beta&job_id=1528
repository: comm-beta
start_time: 2015-04-14T23:13:34
who: kent[at]caspia[dot]com
machine: bld-linux64-spot-157
buildname: TB Linux x86-64 comm-beta build
revision: 7cb2c130de12

TEST-UNEXPECTED-FAIL | check-sync-dirs.py | build file copies are not in sync
make[1]: *** [check-sync-dirs] Error 1
make: *** [check] Error 2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0cb54dc95c80