1154602 - Unable to open .html file via Dropbox Native App

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Capella [:capella]]

Since yesterdays nightly (at least) I've been unable to start Dropbox, select one of my test .html files and have it open in Nightly.

Logcat complains:

D/GeckoSharedPrefs(13906): Current version = 1, prefs version = 1
W/GeckoTabQueueDispatcher(13906): Unable to process tab queue insertion. No URL found! - passed data string: file:///storage/emulated/0/Android/data/com.dropbox.android/files/u146754915/scratch/BugCode/test_bug988143.html

Comment 1

[Mark Capella [:capella]]

Adding cc: for perhaps interested parties

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Looks like TabQueueDispatcher only looks for web urls - assigning to mhaigh.

Comment 3

[Martyn Haigh (:mhaigh)]

Attachment: Unable to open .html file via Dropbox Native

In hindsight the check we perform to see if there's a valid web url in the datastring is unnecessary.  This patch removes that check.

I also changed a finish to a return, as I'm in the file and this needed to happen anyway as the loadNormally function calls finish itself.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8594247 [details] [diff] [review]
Unable to open .html file via Dropbox Native

Review of attachment 8594247 [details] [diff] [review]:
-----------------------------------------------------------------

대박!

Comment 5

[Richard Newman [:rnewman]]

Nice to see mcomella testing Firefox in Korean!

Comment 6

[Martyn Haigh (:mhaigh)]

https://hg.mozilla.org/integration/fx-team/rev/1fe6a64c60da

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1fe6a64c60da

Comment 8

[Teodora Vermesan (:TeoVermesan)]

Reproduced the issue on 14/04 build.
Using the 28/04 build, tapping a .html file from Dropbox and choosing to open with Nightly, will display "Tab queued in Nightly | Open now" toast notification. 
Verified as fixed using:
Device: Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 40.0a1 (2015-04-28)