Closed
Bug 1154648
Opened 9 years ago
Closed 9 years ago
Rename static version of widget/gonk/nsWindow::DispatchInputEvent
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(firefox40 fixed)
RESOLVED
FIXED
2.2 S11 (1may)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: hchang, Assigned: hchang)
Details
Attachments
(1 file, 1 obsolete file)
4.56 KB,
patch
|
mwu
:
review+
|
Details | Diff | Splinter Review |
[1] would hide nsIWidget::DispatchInputEvent. It's better to have a new name. [1] http://hg.mozilla.org/mozilla-central/file/de27ac2ab94f/widget/gonk/nsWindow.h#l55
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → hchang
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aac585865060
Assignee | ||
Updated•9 years ago
|
Attachment #8592722 -
Flags: review?(mwu)
Comment 3•9 years ago
|
||
Comment on attachment 8592722 [details] [diff] [review] Bug1154648.patch Review of attachment 8592722 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/gonk/nsWindow.cpp @@ +233,5 @@ > APZThreadUtils::SetControllerThread(CompositorParent::CompositorLoop()); > } > > /*static*/ nsEventStatus > +nsWindow::DispatchKeyInput(WidgetGUIEvent& aEvent) Can you also change the type of aEvent so it only takes key events?
Updated•9 years ago
|
Attachment #8592722 -
Flags: review?(mwu)
Assignee | ||
Comment 4•9 years ago
|
||
Hi :mwu, Can I have your review again? I changed the type to WidgetKeyboardEvent as you suggested. Thanks!
Attachment #8592722 -
Attachment is obsolete: true
Attachment #8599229 -
Flags: review?(mwu)
Updated•9 years ago
|
Attachment #8599229 -
Flags: review?(mwu) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Thanks for the review!
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/75c059d519b9
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in
before you can comment on or make changes to this bug.
Description
•