Closed Bug 1154648 Opened 9 years ago Closed 9 years ago

Rename static version of widget/gonk/nsWindow::DispatchInputEvent

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
2.2 S11 (1may)
Tracking Status
firefox40 --- fixed

People

(Reporter: hchang, Assigned: hchang)

Details

Attachments

(1 file, 1 obsolete file)

[1] would hide nsIWidget::DispatchInputEvent. It's better to have a new name.

[1] http://hg.mozilla.org/mozilla-central/file/de27ac2ab94f/widget/gonk/nsWindow.h#l55
Assignee: nobody → hchang
Attached patch Bug1154648.patch (obsolete) — Splinter Review
Attachment #8592722 - Flags: review?(mwu)
Comment on attachment 8592722 [details] [diff] [review]
Bug1154648.patch

Review of attachment 8592722 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/gonk/nsWindow.cpp
@@ +233,5 @@
>    APZThreadUtils::SetControllerThread(CompositorParent::CompositorLoop());
>  }
>  
>  /*static*/ nsEventStatus
> +nsWindow::DispatchKeyInput(WidgetGUIEvent& aEvent)

Can you also change the type of aEvent so it only takes key events?
Attachment #8592722 - Flags: review?(mwu)
Attached patch Bug1154648.patchSplinter Review
Hi :mwu,

Can I have your review again? I changed the type to WidgetKeyboardEvent as you suggested. Thanks!
Attachment #8592722 - Attachment is obsolete: true
Attachment #8599229 - Flags: review?(mwu)
Attachment #8599229 - Flags: review?(mwu) → review+
Thanks for the review!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/75c059d519b9
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S11 (1may)
You need to log in before you can comment on or make changes to this bug.