Closed
Bug 1154679
Opened 9 years ago
Closed 9 years ago
Remove is_loosely()
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: Ms2ger, Assigned: ehsan.akhgari)
References
Details
Attachments
(3 files)
2.31 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
2.08 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
3.32 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
Its semantics are quite silly for tests, but I kept it to get bug 949614 landed more easily.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8593619 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8593620 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8593621 -
Flags: review?(Ms2ger)
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8593619 [details] [diff] [review] Part 1: Remove the usage of is_loosely from test_domrequesthelper.xul Review of attachment 8593619 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/base/test/test_domrequesthelper.xul @@ +54,2 @@ > is(dummy._messages, undefined, "Messages is undefined"); > + is(dummy._window, expectedPrivatePropertyValues, "Window is undefined"); Update the messages @@ +71,2 @@ > is(dummy._messages, undefined, "Messages is undefined"); > + is(dummy._window, null, "Window is undefined"); Ditto
Attachment #8593619 -
Flags: review?(Ms2ger) → review+
Reporter | ||
Updated•9 years ago
|
Attachment #8593620 -
Flags: review?(Ms2ger) → review+
Reporter | ||
Updated•9 years ago
|
Attachment #8593621 -
Flags: review?(Ms2ger) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/aba14b2e7628 https://hg.mozilla.org/integration/mozilla-inbound/rev/1cb7031e84ed https://hg.mozilla.org/integration/mozilla-inbound/rev/2506a237287c
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/aba14b2e7628 https://hg.mozilla.org/mozilla-central/rev/1cb7031e84ed https://hg.mozilla.org/mozilla-central/rev/2506a237287c
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•