1154705 - Clone shared-memory test functions in order to test inlining properly

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Lars T Hansen [:lth]]

The test cases in jit-test/tests/atomics/basic-tests.js call test functions on a variety of shared array types.  This plethora of type information confuses the JIT's call optimizer during testing runs; as the tests are written now, only the Int8 primitives are inlined properly, the others are shunted to the interpreter.  The result is poor test coverage (for --ion-eager --ion-offthread-compile=off).

The most reliable fix here is to clone the test function for each type, and this is easily done.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Clone functions that are applied to different array types

Using function.toSource() and eval seemed expedient, but I'm happy to change that if there's a different canonical, reliable way to do this.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8592804 [details] [diff] [review]
Clone functions that are applied to different array types

Review of attachment 8592804 [details] [diff] [review]:
-----------------------------------------------------------------

Seems ok if it makes the test more useful.

Comment 3

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/075804ae0a42

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Backed out for SM(arm) crashes.
https://hg.mozilla.org/integration/mozilla-inbound/rev/a19ec232440d

https://treeherder.mozilla.org/logviewer.html#?job_id=9069441&repo=mozilla-inbound

Comment 5

[Lars T Hansen [:lth]]

Yeah, the cloned test cases show their value: more diverse jitted code is being generated, which means that a missing instruction in the ARM simulator (UXTH) is being hit, I have that fix in a later patch but I guess I'll move it :)

Comment 6

[Lars T Hansen [:lth]]

Try is green for this patch on top of bug 1156386, which implements UXTH:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecb70a782d4f

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ff8096ab54b

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1ff8096ab54b