1154708 - Drop renaming conversations from the panel

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

Now that we've removed the urls from the conversations in the panel due to the context work; it really feels like you should be able to click the conversation name to open the conversation, rather than rename it.

We've checked with RT, and he's fine with us removing the option from the panel.

Comment 1

[Mark Banner (:standard8)]

Attachment: Drop renaming conversations from the Loop panel.

Mainly simple removals of the renaming functionality and tests. I've also changed the pointer to be the default as per the panel design refresh currently attached to bug 1130074 (attachment 8588815 [details]).

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8592876 [details] [diff] [review]
Drop renaming conversations from the Loop panel.

Review of attachment 8592876 [details] [diff] [review]:
-----------------------------------------------------------------

Mmmm, tasty tasty code removal!  r=dmose

::: browser/components/loop/content/css/panel.css
@@ +252,5 @@
>  }
>  
>  .room-list > .room-entry {
>    padding: .5rem 1rem;
> +  cursor: default;

Does this need to be default?  Or could the line just be removed entirely?

Comment 3

[Mark Banner (:standard8)]

(In reply to Dan Mosedale (:dmose) - needinfo? me for response from comment #2)
> >  .room-list > .room-entry {
> >    padding: .5rem 1rem;
> > +  cursor: default;
> 
> Does this need to be default?  Or could the line just be removed entirely?

Its needed to override the pointer for the text part of the room entry (i.e. the room title) as per the ux. I've added a comment.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/68dd78095c24

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/68dd78095c24