Closed Bug 1154719 Opened 9 years ago Closed 9 years ago

Return a Promise from nsIServiceWorkerManager::propagateSoftUpdate() to let about:serviceworkers reload itself once the update operation is finished

Categories

(Core :: DOM: Service Workers, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
FxOS-S3 (24Jul)

People

(Reporter: ehsan.akhgari, Assigned: jaoo)

References

Details

      No description provided.
Assignee: nobody → jaoo
Component: DOM → DOM: Service Workers
Whiteboard: [s4]
Target Milestone: --- → NGA S3 (26Jun)
Status: NEW → ASSIGNED
Whiteboard: [s4]
Target Milestone: NGA S3 (26Jun) → FxOS-S1 (26Jun)
Target Milestone: FxOS-S1 (26Jun) → FxOS-S2 (10Jul)
Target Milestone: FxOS-S2 (10Jul) → FxOS-S3 (24Jul)
Summary: Return a Promise from nsIServiceWorkerManager::Update() to let about:serviceworkers reload itself once the update operation is finished → Return a Promise from nsIServiceWorkerManager::propagateSoftUpdate() to let about:serviceworkers reload itself once the update operation is finished
Will this be really needed? I mean, do you plan to keep this method in the nsIServiceWorkerManager interface during the refactor of the SWM you are working on? Thanks!
Flags: needinfo?(catalin.badea392)
(In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> Will this be really needed? I mean, do you plan to keep this method in the
> nsIServiceWorkerManager interface during the refactor of the SWM you are
> working on? Thanks!

No, all Propagate methods should be eventually removed.
Flags: needinfo?(catalin.badea392)
(In reply to Cătălin Badea (:catalinb) from comment #2)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #1)
> > Will this be really needed? I mean, do you plan to keep this method in the
> > nsIServiceWorkerManager interface during the refactor of the SWM you are
> > working on? Thanks!
> 
> No, all Propagate methods should be eventually removed.

Having said that I think we should resolve this bug. Right now is not really needed. Existing tests of the about:sw logic deal with the method as it is today and there is no need for the method to return the promise. If anyone around disagrees, please reopen the bug. Thanks.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.