Closed Bug 1154734 Opened 5 years ago Closed 5 years ago

Wheel events can be misrouted if used in APZ-less widgets when APZ is enabled

Categories

(Core :: Panning and Zooming, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file)

If APZ is enabled, but a widget isn't using APZ, then ESM will ignore the scroll action for wheel events. We need to be more specific in how we determine which main-thread events were handled by APZ.
Attached patch fixSplinter Review
Attachment #8592827 - Flags: review?(bugmail.mozilla)
Comment on attachment 8592827 [details] [diff] [review]
fix

Review of attachment 8592827 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: widget/BasicEvents.h
@@ +539,5 @@
>    // for when the parent process need the know first how the event was used
>    // by content before handling it itself.
>    bool mWantReplyFromContentProcess : 1;
> +  // The event's action will be handled by APZ. The main thread should not
> +  // perform its associated action.

Add "Currently only relevant for wheel events"
Attachment #8592827 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/6ee1d3e056b3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.