1154754 - Implement Client.postMessage message source

Status: RESOLVED DUPLICATE of bug 1143717

(Core :: DOM: Core & HTML, defect)

Description

[Cătălin Badea (:catalinb)]

Messages dispatched by the service worker to a service worker client should have a source object.

Comment 1

[Cătălin Badea (:catalinb)]

Attachment: Add source to messages dispatched by ServiceWorkerClient.postMessage.

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8592856 [details] [diff] [review]
Add source to messages dispatched by ServiceWorkerClient.postMessage.

Review of attachment 8592856 [details] [diff] [review]:
-----------------------------------------------------------------

You cannot pass around the worker private to the main thread without ensuring it stays alive. It seems like you only need the ID though, so why not just pass that?
Where was the ID introduced?

::: dom/workers/ServiceWorkerClient.cpp
@@ +142,5 @@
>        xpc::Throw(aCx, NS_ERROR_DOM_DATA_CLONE_ERR);
>        return NS_ERROR_FAILURE;
>      }
>  
> +    nsRefPtr<nsIDOMMessageEvent> event = new MessageEvent(aTargetContainer,

Use nsRefPtr<MessageEvent>...

@@ +156,5 @@
>        xpc::Throw(aCx, rv);
>        return NS_ERROR_FAILURE;
>      }
>  
> +    static_cast<MessageEvent*>(event.get())->SetSource(aSource);

...and you don't need this cast.

Comment 3

[Cătălin Badea (:catalinb)]

(In reply to Nikhil Marathe [:nsm] (needinfo? please) from comment #2)
> Comment on attachment 8592856 [details] [diff] [review]
> Add source to messages dispatched by ServiceWorkerClient.postMessage.
> 
> Review of attachment 8592856 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> You cannot pass around the worker private to the main thread without
> ensuring it stays alive. It seems like you only need the ID though, so why
> not just pass that?
An oversight, I'll fix it.

> Where was the ID introduced?
Please see bug 1130684. I expect you'll have some comments about the id thing.

> ::: dom/workers/ServiceWorkerClient.cpp
> @@ +142,5 @@
> >        xpc::Throw(aCx, NS_ERROR_DOM_DATA_CLONE_ERR);
> >        return NS_ERROR_FAILURE;
> >      }
> >  
> > +    nsRefPtr<nsIDOMMessageEvent> event = new MessageEvent(aTargetContainer,
> 
> Use nsRefPtr<MessageEvent>...
> 
> @@ +156,5 @@
> >        xpc::Throw(aCx, rv);
> >        return NS_ERROR_FAILURE;
> >      }
> >  
> > +    static_cast<MessageEvent*>(event.get())->SetSource(aSource);
> 
> ...and you don't need this cast.

MessageEvent's downcast to nsIDOMMessageEvent is ambiguous (which is the argument type of the dispatch event method). Either way, I'll need a cast.

Comment 4

[(no longer active)]

Catalin, are you still planning to work on this?

Thanks!

Comment 5

[Cătălin Badea (:catalinb)]

This was fixed by dimi in bug 1143717.