JavaScript strict warning: resource://gre/modules/ObjectUtils.jsm, line 93: ReferenceError: reference to undefined property a.prototype

RESOLVED FIXED in Firefox 40

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Yoric, Assigned: amovah, Mentored)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [lang=js][good first bug])

Attachments

(1 attachment, 2 obsolete attachments)

I see this when running tests. We could fix this in ObjectUtils.jsm line 93
by replacing `a.prototype != b.prototype` with `(a.prototype || undefined)  != (b.prototype || undefined)`.
Assignee

Comment 1

4 years ago
Posted patch rev1 - Fix it (obsolete) — Splinter Review
I'm interested in fix this issue, Can I?
Attachment #8594510 - Flags: review?(dteller)
Comment on attachment 8594510 [details] [diff] [review]
rev1 - Fix it

Review of attachment 8594510 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Try results will show here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6d9ba3dd6bfe
Attachment #8594510 - Flags: review?(dteller) → review+
Sorry, wrong address. Try results showed up here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e38b657da354

These results look good. Let's try to land it!
Assignee: nobody → aligeekjs
Keywords: checkin-needed
Assignee

Updated

4 years ago
Status: NEW → ASSIGNED
Ohoh, it looks like there's a syntax error in the patch, which causes errors here: https://treeherder.mozilla.org/logviewer.html#?job_id=2760167&repo=fx-team

Can you please fix the syntax of the `if`?
Flags: needinfo?(aligeekjs)
Assignee

Comment 5

4 years ago
Posted patch rev2 - Fix if syntax (obsolete) — Splinter Review
I think that I've fixed it.
Flags: needinfo?(aligeekjs)
Attachment #8595283 - Flags: review?(dteller)
Comment on attachment 8595283 [details] [diff] [review]
rev2 - Fix if syntax

Review of attachment 8595283 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, that should do the trick.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cecbbfe6c18e
Attachment #8595283 - Flags: review?(dteller) → review+
Posted patch Folded patchSplinter Review
Attachment #8594510 - Attachment is obsolete: true
Attachment #8595283 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/844fd3a2a85e
Keywords: checkin-needed
Whiteboard: [lang=js][good first bug] → [lang=js][good first bug][fixed-in-fx-team]
Why does Pulsebot reference the old patch and not the new one?
https://hg.mozilla.org/mozilla-central/rev/844fd3a2a85e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js][good first bug][fixed-in-fx-team] → [lang=js][good first bug]
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.