1154776 - nsTransitionManager.h:44:44: error: 'AsTransition' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]

Status: RESOLVED DUPLICATE of bug 1004383

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

New clang >3.6 build warning (treated as error for warnings-as-error builds):
{
nsTransitionManager.h:44:44: error: 'AsTransition' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
}

This function was added in this cset:
  http://hg.mozilla.org/mozilla-central/rev/5177486bb831
and was missing the 'override' keyword.

Comment 1

[Daniel Holbert [:dholbert]]

Landing a fix shortly, with blanket r+ that ehsan granted me for fixes of this sort over in bug 1126447 comment 2.

(I hit several other build errors of the same sort, in other parts of the tree, and I'm prepping commits to fix all of them in a single push.)

Comment 2

[Daniel Holbert [:dholbert]]

Looks like ehsan already fixed this on inbound, actually. (in https://hg.mozilla.org/integration/mozilla-inbound/rev/c20a148abbb0 )

Comment 3

[Daniel Holbert [:dholbert]]

duping back to the original bug 1004383, since that's the bug number in ehsan's commit.