Closed Bug 1154827 Opened 5 years ago Closed 5 years ago

Create a basic container for cross compiling linux32 builds

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox41 fixed)

RESOLVED FIXED
Tracking Status
firefox41 --- fixed

People

(Reporter: mrrrgn, Assigned: mrrrgn)

References

Details

Attachments

(2 files, 3 obsolete files)

This should have parity with the base Linux64 containers.
Blocks: 1151508
Assignee: nobody → winter2718
Attached patch ubuntu32.diff (obsolete) — Splinter Review
Attachment #8622566 - Flags: review?(dustin)
Attached patch ubuntu32.diffSplinter Review
Goofed up a cp and placed files in the root docker dir in the old patch.
Attachment #8622566 - Attachment is obsolete: true
Attachment #8622566 - Flags: review?(dustin)
Attachment #8622575 - Flags: review?(dustin)
Attached file build-sh-split (obsolete) —
Attachment #8622768 - Flags: review?
Attached patch buildscriptintree.diff (obsolete) — Splinter Review
This splits up the logic without breaking the current try jobs.
Attachment #8622768 - Attachment is obsolete: true
Attachment #8622768 - Flags: review?
Attachment #8623031 - Flags: review?(dustin)
Comment on attachment 8623031 [details] [diff] [review]
buildscriptintree.diff

This is not even the right patch. *_*
Attachment #8623031 - Attachment is obsolete: true
Attachment #8623031 - Flags: review?(dustin)
Depends on: 1175126
Comment on attachment 8622575 [details] [diff] [review]
ubuntu32.diff

Review of attachment 8622575 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!

::: testing/docker/ubuntu32-build/build-setup.sh
@@ +5,5 @@
> +test `whoami` == 'root';
> +
> +# This is a known workaround for a Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/430224
> +dpkg-divert --rename --add /usr/sbin/invoke-rc.d
> +ln -s /bin/true /usr/sbin/invoke-rc.d

Funny how a long search ends up with such a short fix.  This should probably end up in bootstrap -- is there a bug filed for that so it's not forgotten?
Attachment #8622575 - Flags: review?(dustin) → review+
(In reply to Dustin J. Mitchell [:dustin] from comment #6)
> Comment on attachment 8622575 [details] [diff] [review]
> ubuntu32.diff
> 
> Review of attachment 8622575 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Awesome!
> 
> ::: testing/docker/ubuntu32-build/build-setup.sh
> @@ +5,5 @@
> > +test `whoami` == 'root';
> > +
> > +# This is a known workaround for a Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/430224
> > +dpkg-divert --rename --add /usr/sbin/invoke-rc.d
> > +ln -s /bin/true /usr/sbin/invoke-rc.d
> 
> Funny how a long search ends up with such a short fix.  This should probably
> end up in bootstrap -- is there a bug filed for that so it's not forgotten?

Agreed. I think it would be faster if I was a few IQ points more clever. C'est la vie. 

Bootstrap bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1175184
Attached patch desktop32.diffSplinter Review
Note: this patch relies on https://bugzilla.mozilla.org/show_bug.cgi?id=1175126 being merged
Attachment #8623135 - Flags: review?(dustin)
Comment on attachment 8623135 [details] [diff] [review]
desktop32.diff

Review of attachment 8623135 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/docker/desktop32-build/bin/build.sh
@@ +8,5 @@
> +####
> +
> +. $HOME/bin/checkout-sources.sh
> +
> +. $WORKSPACE/build/src/testing/taskcluster/scripts/builder/build-linux.sh

:heart:
Attachment #8623135 - Flags: review?(dustin) → review+
Attachment #8622575 - Flags: checked-in+
Attachment #8623135 - Flags: checked-in+
Nice work Morgan!
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.