1154827 - Create a basic container for cross compiling linux32 builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Morgan Phillips [:mrrrgn]]

This should have parity with the base Linux64 containers.

Comment 1

[Morgan Phillips [:mrrrgn]]

Attachment: ubuntu32.diff

Comment 2

[Morgan Phillips [:mrrrgn]]

Attachment: ubuntu32.diff

Goofed up a cp and placed files in the root docker dir in the old patch.

Comment 3

[Morgan Phillips [:mrrrgn]]

Attachment: build-sh-split

Comment 4

[Morgan Phillips [:mrrrgn]]

Attachment: buildscriptintree.diff

This splits up the logic without breaking the current try jobs.

Comment 5

[Morgan Phillips [:mrrrgn]]

Comment on attachment 8623031 [details] [diff] [review]
buildscriptintree.diff

This is not even the right patch. *_*

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8622575 [details] [diff] [review]
ubuntu32.diff

Review of attachment 8622575 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!

::: testing/docker/ubuntu32-build/build-setup.sh
@@ +5,5 @@
> +test `whoami` == 'root';
> +
> +# This is a known workaround for a Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/430224
> +dpkg-divert --rename --add /usr/sbin/invoke-rc.d
> +ln -s /bin/true /usr/sbin/invoke-rc.d

Funny how a long search ends up with such a short fix.  This should probably end up in bootstrap -- is there a bug filed for that so it's not forgotten?

Comment 7

[Morgan Phillips [:mrrrgn]]

(In reply to Dustin J. Mitchell [:dustin] from comment #6)
> Comment on attachment 8622575 [details] [diff] [review]
> ubuntu32.diff
> 
> Review of attachment 8622575 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Awesome!
> 
> ::: testing/docker/ubuntu32-build/build-setup.sh
> @@ +5,5 @@
> > +test `whoami` == 'root';
> > +
> > +# This is a known workaround for a Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/upstart/+bug/430224
> > +dpkg-divert --rename --add /usr/sbin/invoke-rc.d
> > +ln -s /bin/true /usr/sbin/invoke-rc.d
> 
> Funny how a long search ends up with such a short fix.  This should probably
> end up in bootstrap -- is there a bug filed for that so it's not forgotten?

Agreed. I think it would be faster if I was a few IQ points more clever. C'est la vie. 

Bootstrap bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1175184

Comment 8

[Morgan Phillips [:mrrrgn]]

Attachment: desktop32.diff

Note: this patch relies on https://bugzilla.mozilla.org/show_bug.cgi?id=1175126 being merged

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8623135 [details] [diff] [review]
desktop32.diff

Review of attachment 8623135 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/docker/desktop32-build/bin/build.sh
@@ +8,5 @@
> +####
> +
> +. $HOME/bin/checkout-sources.sh
> +
> +. $WORKSPACE/build/src/testing/taskcluster/scripts/builder/build-linux.sh

:heart:

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cb820f427d8
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb60a073ee00

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1cb820f427d8
https://hg.mozilla.org/mozilla-central/rev/cb60a073ee00

Comment 12

[Pete Moore [:pmoore][:pete]]

Nice work Morgan!