Closed Bug 1154850 Opened 9 years ago Closed 9 years ago

"Backoff request had non-numeric value: None"

Categories

(Firefox Graveyard :: Reading List, defect)

Product:
Firefox Graveyard
Component:
Reading List
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox40 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 40
Tracking Flags:
Tracking Status
firefox40 --- fixed

People

(Reporter: adw, Assigned: adw)

Details

Attachments

(1 file, 1 obsolete file)

patch v2
1.76 KB, patch
markh
: review+
Details | Diff | Splinter Review
Attached patch convert "None" to 0 (obsolete) — — Splinter Review 
Seeing this in all my logs.
Attachment #8592958 - Flags: review?(mhammond)
Doh! I wonder if we should check for None in ServerClient.jsm? It seems a waste to send this observer notification on every single request.
Attached patch patch v2 — — Splinter Review 

        Attachment #8592958 -
        Attachment is obsolete: true

        Attachment #8592958 -
        Flags: review?(mhammond)

        Attachment #8593649 -
        Flags: review?(mhammond)

    
  
OS: Mac OS X → All
Hardware: x86 → All

    
    

    
  
Comment on attachment 8593649 [details] [diff] [review]
patch v2

Review of attachment 8593649 [details] [diff] [review]:
-----------------------------------------------------------------

I would also have been fine with just a guard for an explicit "none" :)

        Attachment #8593649 -
        Flags: review?(mhammond) → review+

    
    

    
  
Thanks Mark.
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/738e72f8b1ec
Status: ASSIGNED → RESOLVED
Closed: 9 years ago

          status-firefox40:
          affected → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: