Closed Bug 1154864 Opened 5 years ago Closed 5 years ago

Fix getScopeByLocalId use in PushService.jsm

Categories

(Core :: DOM: Push Notifications, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(1 file)

This is used in http://hg.mozilla.org/mozilla-central/annotate/b58b07945d30/dom/push/PushService.jsm#l378 but was not implemented. Unfortunately that blows up a bit in some tests.
Just returning null for now to make the js engine happy.
Attachment #8592983 - Flags: review?(nsm.nikhil)
Comment on attachment 8592983 [details] [diff] [review]
getlocalscope.patch

Review of attachment 8592983 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/AppsService.js
@@ +151,5 @@
> +    debug("getScopeByLocalId( " + aLocalId + " )");
> +    if (this.isInvalidId(aLocalId)) {
> +      return null;
> +    }
> +    // TODO : implement properly!

Please explain why this is required but null for now in the comment.
Attachment #8592983 - Flags: review?(nsm.nikhil) → review+
https://hg.mozilla.org/mozilla-central/rev/1cbb2b277958
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.