1154894 - Disable test_plugin_default_state.js so Thunderbird can ship with plugins disabled by default

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Comment 1

[aleth [:aleth]]

An alternative would be to change the test so it quits early instead of failing if plugins are disabled by default. Not sure whether that would be more or less likely to get review than a change to xpcshell.ini...

Comment 2

[Kent James (:rkent)]

My guess is that a change to xpcshell.ini that simply disabled the test for Thunderbird would be the easiest sell.

Comment 3

[Kent James (:rkent)]

Attachment: Disable tests that need plugins

This will disable the tests that are failing when bug 1138154 lands. This is an m-c patch.

Comment 4

[Magnus Melin [:mkmelin]]

Submit it for review?

Comment 5

[aleth [:aleth]]

Comment on attachment 8595615 [details] [diff] [review]
Disable tests that need plugins

Review of attachment 8595615 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/test/unit/xpcshell.ini
@@ +25,2 @@
>  [test_plugin_default_state_xpi.js]
> +skip-if = appname == "thunderbird"

You probably don't need to disable this test unless you plan to change the pref("plugin.defaultXpi.state", 2); in the patch in bug 1138154 (that keeps plugins bundled in addons enabled).

Comment 6

[Kent James (:rkent)]

Attachment: Disable two tests

Comment 7

[John Schoenick [:johns]]

Comment on attachment 8597056 [details] [diff] [review]
Disable two tests

So the issue here is that the test is asserting that the default plugin state is not disabled - but the test is also testing other things, e.g. ensuring that the pref works. I'm not sure I see the value in the | defaultState == DISABLED | assertion, that could probably be removed and let the test continue to test the functionality of the pref on all apps.

I have little history here though, I think :bsmedberg would be the better person to ask on what our policy is WRT thunderbird and plugin tests

Comment 8

[Benjamin Smedberg]

Comment on attachment 8597056 [details] [diff] [review]
Disable two tests

I'm ok with these skip-ifs. I'd prefer to keep the default-state check for Firefox since we don't have any other check for this fairly important setting.

Comment 9

[Kent James (:rkent)]

Pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/21701097dafb

Comment 10

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=comm-central&job_id=18222
repository: comm-central
start_time: 2015-05-13T12:29:17
who: kent[at]caspia[dot]com
machine: tst-linux32-spot-124
buildname: Ubuntu VM 12.04 comm-central opt test xpcshell
revision: d294256abf7b

TEST-UNEXPECTED-FAIL | dom/plugins/test/unit/test_plugin_default_state.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | dom/plugins/test/unit/test_plugin_default_state.js | run_test - [run_test : 6] 0 != 0
TEST-UNEXPECTED-FAIL | dom/plugins/test/unit/test_persist_in_prefs.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | services/fxaccounts/tests/xpcshell/test_web_channel.js | xpcshell return code: 0
TypeError: Cc['@mozilla.org/weave/service;1'] is undefined at resource://gre/modules/FxAccountsWebChannel.jsm:227
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySendOldPings.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySendOldPings.js | test_overdue_old_format - [test_overdue_old_format : 116] 0 == 4
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySession.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | toolkit/components/telemetry/tests/unit/test_TelemetrySession.js | test_saveLoadPing - [test_saveLoadPing : 275] 0 == 1
Return code: 1

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/21701097dafb