Disable test_plugin_default_state.js so Thunderbird can ship with plugins disabled by default

RESOLVED FIXED in Firefox 41

Status

()

RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: rkent, Assigned: rkent)

Tracking

Trunk
mozilla41
x86_64
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox41 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)

Comment 1

4 years ago
An alternative would be to change the test so it quits early instead of failing if plugins are disabled by default. Not sure whether that would be more or less likely to get review than a change to xpcshell.ini...
(Assignee)

Comment 2

4 years ago
My guess is that a change to xpcshell.ini that simply disabled the test for Thunderbird would be the easiest sell.
(Assignee)

Comment 3

4 years ago
Created attachment 8595615 [details] [diff] [review]
Disable tests that need plugins

This will disable the tests that are failing when bug 1138154 lands. This is an m-c patch.
Assignee: nobody → rkent
Status: NEW → ASSIGNED
Submit it for review?

Comment 5

4 years ago
Comment on attachment 8595615 [details] [diff] [review]
Disable tests that need plugins

Review of attachment 8595615 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/test/unit/xpcshell.ini
@@ +25,2 @@
>  [test_plugin_default_state_xpi.js]
> +skip-if = appname == "thunderbird"

You probably don't need to disable this test unless you plan to change the pref("plugin.defaultXpi.state", 2); in the patch in bug 1138154 (that keeps plugins bundled in addons enabled).
(Assignee)

Updated

4 years ago
Component: Security → Plug-ins
Product: MailNews Core → Core
Version: 38 → Trunk
(Assignee)

Comment 6

4 years ago
Created attachment 8597056 [details] [diff] [review]
Disable two tests
Attachment #8595615 - Attachment is obsolete: true
Attachment #8597056 - Flags: review?(john)
Comment on attachment 8597056 [details] [diff] [review]
Disable two tests

So the issue here is that the test is asserting that the default plugin state is not disabled - but the test is also testing other things, e.g. ensuring that the pref works. I'm not sure I see the value in the | defaultState == DISABLED | assertion, that could probably be removed and let the test continue to test the functionality of the pref on all apps.

I have little history here though, I think :bsmedberg would be the better person to ask on what our policy is WRT thunderbird and plugin tests
Attachment #8597056 - Flags: review?(john) → review?(benjamin)
(Assignee)

Updated

3 years ago
Blocks: 1138154

Comment 8

3 years ago
Comment on attachment 8597056 [details] [diff] [review]
Disable two tests

I'm ok with these skip-ifs. I'd prefer to keep the default-state check for Firefox since we don't have any other check for this fairly important setting.
Attachment #8597056 - Flags: review?(benjamin) → review+
Comment hidden (Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/21701097dafb
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
(Assignee)

Updated

3 years ago
Blocks: 1165152
You need to log in before you can comment on or make changes to this bug.