1154901 - mozilla-download never thinks $GAIA/b2g is up-to-date

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

The issue is that if you have an out-of-date $GAIA/b2g we'll download new stuff and copy it into the directory instead of clobbering the existing b2g dir which doesn't update the b2g dir's timestamp (only the timestamp of its children) so make gets tripped up.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] gaye:bug-1154901 > mozilla-b2g:master

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29529

Just a little patch to make sure that $GAIA/b2g timestamp gets updated when we run |make b2g|

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 8593019 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/29529

I'm bit overloaded these days and Ricky has a better knowledge of the build system now.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Patch looks fine to me but I don't totally understand why we have to update b2g's timestamp?

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Ricky Chien [:rickychien] from comment #4)
> Patch looks fine to me but I don't totally understand why we have to update
> b2g's timestamp?

Make determines whether a target needs to be re-made based on the target's timestamps and the timestamps of its dependencies.  Without this fix, on OS X, the timestamp of b2g will never be updated after it's initially created.  However, we update node_modules all the time, so node_modules (as well as the current dep "node_modules/.bin/mozilla-download" that's being simplified to node_modules) can easily end up with more recent timestamps.  Once that happens, OS X users will find that every time "make b2g" is invoked (or anything depending on the "b2g" target), make will decide that it needs to rebuild the "b2g" target and re-run its rules which means re-downloading b2g.

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Thanks for explanation :asuth! https://github.com/mozilla-b2g/gaia/commit/3cd0a9facce26c2acc7be3755a17131a6358e33f landed on master