1154950 - Share our process-global marking paths

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: 9_share_process_global_tracing_fns-v0.diff

MarkPermanentAtom and MarkWellKnownSymbol are identical except for an assertion. The assertion doesn't seem to be adding much that isn't already asserted elsewhere, so I'd rather have the copy-paste gone than the assertion.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8593060 [details] [diff] [review]
9_share_process_global_tracing_fns-v0.diff

Review of attachment 8593060 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good to me. Just notes on a pre-existing comment.

::: js/src/gc/Marking.cpp
@@ +376,5 @@
> +    JS_ROOT_MARKING_ASSERT(trc);
> +    MOZ_ASSERT(ThingIsPermanentAtomOrWellKnownSymbol(thing));
> +
> +    // We have to mark permanent atoms through a special method because the
> +    // default DoMarking implementation automatically skips them. Fortunatly,

*Fortunately

@@ +377,5 @@
> +    MOZ_ASSERT(ThingIsPermanentAtomOrWellKnownSymbol(thing));
> +
> +    // We have to mark permanent atoms through a special method because the
> +    // default DoMarking implementation automatically skips them. Fortunatly,
> +    // atoms cannot refer to other GC things, so they do not need to go through

symbols and atoms?

Comment 2

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=67bed89de177

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/037b2e086aa6

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/037b2e086aa6