Closed
Bug 1154955
Opened 10 years ago
Closed 7 years ago
OS.file.open with |write| mode does not fail even if target file has no write permission on B2G
Categories
(Toolkit Graveyard :: OS.File, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: hiro, Unassigned)
References
Details
Attachments
(3 files)
1.23 KB,
patch
|
Details | Diff | Splinter Review | |
1.93 KB,
patch
|
Details | Diff | Splinter Review | |
4.37 KB,
patch
|
Details | Diff | Splinter Review |
Attachment file is a POC, you can easily confirm this issue.
Updated•10 years ago
|
Flags: needinfo?(dteller)
Reporter | ||
Comment 1•10 years ago
|
||
The root cause is that |open| in bionic is a variadic function. So this issue will happen on Android too.
Comment 2•10 years ago
|
||
If you have a clear idea on how to fix this, hiro, I can review your patch.
Flags: needinfo?(dteller) → needinfo?(hiikezoe)
Reporter | ||
Comment 3•10 years ago
|
||
There is another issue in osfile_unix_front.jsm.
The third argument of open() is set if not creation mode.
Flags: needinfo?(hiikezoe)
Reporter | ||
Comment 4•10 years ago
|
||
Now I just pushed these patches on try.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac5101dab47b
I will request review after the try result looks good.
Reporter | ||
Comment 5•10 years ago
|
||
The try failed.
The test I added in patch does sometimes fails.
I am guessing some other issues remain there.
Reporter | ||
Comment 6•10 years ago
|
||
I've been totally misunderstanding this issue.
The *real* root cause of this issue is that xpcshell test runs with root privilege on b2g emulator.
So test relying on no write access like test_error_target in common_test_Download.js fails on b2g emulator.
Comment 7•7 years ago
|
||
Closing this old B2G bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Updated•2 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•