Closed
Bug 1154988
Opened 9 years ago
Closed 9 years ago
[Calendar] remove db initialization and store factory from app.js
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mmedeiros, Assigned: mmedeiros)
References
Details
Attachments
(1 file)
right now we instantiate the database inside the app.js file, I think we should remove the `db` instance from the app module and convert it into a Singleton/Static or create a SingletonFactory. there are a couple places that access `app.db` and many others that call `app.store()` (which calls `this.db.getStore()`) this will reduce the likelihood of circular dependencies and almost kill the need of passing the app instance to all the views & controllers.
Assignee | ||
Updated•9 years ago
|
Summary: remove db initialization and store factory from app.js → [Calendar] remove db initialization and store factory from app.js
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mmedeiros
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8598974 [details] [review] [gaia] millermedeiros:1154988-store-db-app-refactor > mozilla-b2g:master Great work Miller. I only had one nit on GH. Not flagging checkin-needed since the commits still need to be squashed.
Attachment #8598974 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 4•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/e4e4c615052cec68cfad4c67e1cd22988727f978
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•