Closed Bug 1154990 Opened 4 years ago Closed 4 years ago

Better error messages when sending fails

Categories

(Core :: IPC, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We usually print a couple messages like this when shutting down:

###!!! [Child][MessageChannel] Error: Channel closing: too late to send/recv, messages will be lost

This patch changes it to:

###!!! [Child][MessageChannel] Error: (msgtype=0x3800D4,name=PContent::Msg_AsyncMessage) Channel closing: too late to send/recv, messages will be lost

which I think is a lot more useful. Maybe people will start fixing these.
Attachment #8593111 - Flags: review?(bent.mozilla)
Comment on attachment 8593111 [details] [diff] [review]
patch

r+double+plus!
Attachment #8593111 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/810e6ad6259c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.