Better error messages when sending fails

RESOLVED FIXED in Firefox 40

Status

()

Core
IPC
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

Trunk
mozilla40
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

5.14 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Created attachment 8593111 [details] [diff] [review]
patch

We usually print a couple messages like this when shutting down:

###!!! [Child][MessageChannel] Error: Channel closing: too late to send/recv, messages will be lost

This patch changes it to:

###!!! [Child][MessageChannel] Error: (msgtype=0x3800D4,name=PContent::Msg_AsyncMessage) Channel closing: too late to send/recv, messages will be lost

which I think is a lot more useful. Maybe people will start fixing these.
Attachment #8593111 - Flags: review?(bent.mozilla)
Comment on attachment 8593111 [details] [diff] [review]
patch

r+double+plus!
Attachment #8593111 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/810e6ad6259c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.