If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Deal with self-hosted builtins when stringifying tracked optimization type info

RESOLVED FIXED in Firefox 40

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: shu, Unassigned)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
An interpreted JSFunction can be in 3 states:

1. isInterpreted(), has JSScript
2. isInterpretedLazy(), with LazyScript
3. isInterpretedLazy(), without LazyScript (self-hosted builtins)

Currently the optimization type info streaming stuff doesn't deal with 3, and sometimes crashes.
(Reporter)

Comment 1

3 years ago
Created attachment 8593120 [details] [diff] [review]
Deal with self-hosted builtins when stringifying tracked optimization type info.

Also made lineno into a Maybe<unsigned> from unsigned* while I was here.
Attachment #8593120 - Flags: review?(kvijayan)
Comment on attachment 8593120 [details] [diff] [review]
Deal with self-hosted builtins when stringifying tracked optimization type info.

Review of attachment 8593120 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/ProfileEntry.cpp
@@ +127,5 @@
>      // Wrapping around may result in things referenced in the buffer (e.g.,
>      // JIT code addresses and markers) being incorrectly collected.
>      MOZ_ASSERT(mGeneration != UINT32_MAX);
>      mGeneration++;
> +    fprintf(stderr, ">> SHU [%p] mGeneration %u\n", this, mGeneration);

Nit: remove debugging printf.
Attachment #8593120 - Flags: review?(kvijayan) → review+

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/66eee8b402fd
https://hg.mozilla.org/mozilla-central/rev/66eee8b402fd
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.