1155015 - haXe-Starling demo fails due to document.fonts error

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Alon Zakai (:azakai)]

The HTML5 demo on this page

http://blog.peteshand.net/starling-for-haxe/

fails to load on firefox nightly with "NS_ERROR_NOT_IMPLEMENTED:".

The failing line is

  if(window.document.fonts && window.document.fonts.load) window.document.fonts.load("1em '" + font + "'").then(function(_) {

so looks like something to do with document.fonts.

The page works properly in chrome.

Comment 1

[Boris Zbarsky [:bzbarsky]]

FontFaceSet::Load just always throws NS_ERROR_NOT_IMPLEMENTED.  So yes, the line above would fail.

Seems to me like we should put load() behind a separate pref from the main font API, if we're not going to implement it at the same time...  or flip back the pref on the main font API, becuase otherwise we'll break stuff on nightly and aurora.

The bug tracking implementing load() is bug 1072102, fwiw.

Comment 2

[Cameron McCormack (:heycam)]

Is there an advantage to putting load/check behind a separate pref?  How about just commenting out the IDL bits for load/check and then once we land support for them put them under the existing Font Loading API pref?

Comment 3

[Boris Zbarsky [:bzbarsky]]

That sounds just fine too, yes.

Comment 4

[Cameron McCormack (:heycam)]

Attachment: patch

I trust this patch is small enough to bypass your "not doing reviews" filter. :)

Turns out we already had check commented out, too.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8593678 [details] [diff] [review]
patch

r=me

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc1d404bec20

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc1d404bec20