1155088 - [Messages] FDN error warnning dialog will not be displayed while resending the message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Steve Chung [:steveck]]

[Blocking Requested - why for this release]:

In the resend mechanism we should displayed the error dialog again if message resending still return error. But it seems not working for FDN error case. Here is the reproduce step:

1) Enable the sim FDN in settings
2) Open a message and send sms to a number not in FDN list
3) Should see the FDN error dialog return. 
4) Long press on the message and click resend option.

Expected result:
See the FDN error dialog again.

Actual result:
Nothing happend, with console error log: JavaScript Error: "TypeError: options.recipients is undefined"

It's because of the resend message didn't consider the FDN error no more option is given for error dialog. Although FDN error is not a common case and this bug should be existed at the very begining stage, we might still need to fix it someday because user will have no idea why the message resending still failed.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] steveck-chung:message-FDN-error > mozilla-b2g:master

Comment 2

[Steve Chung [:steveck]]

Comment on attachment 8593282 [details] [review]
[gaia] steveck-chung:message-FDN-error > mozilla-b2g:master

Hi Oleg, it's tiny patch for resend case fixing. Take your time since it's not blocker yet :)

Comment 3

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8593282 [details] [review]
[gaia] steveck-chung:message-FDN-error > mozilla-b2g:master

Thanks for the quick fix. I've just left one optional suggestion, but if you don't think it's good, just go ahead and land the patch!

Comment 4

[Steve Chung [:steveck]]

Make it simpler sounds good, Patch updated per your suggestion, thanks!

Comment 5

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#sFZrw0QHTuCH2oNtFa-ilA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 6

[Steve Chung [:steveck]]

Unrelated failed test in gaia build, so merge it manually.
Landed in master: https://github.com/mozilla-b2g/gaia/commit/4fadab1b75830a63d5b2c9ace1e6e1c1cd4899c9

Comment 7

[Johan Lorenzo [:jlorenzo]]

Already landed in 3.0.