1155099 - [l12y][FM Radio]All locales: The words "MHz" on the main radio view is not localizable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect, P2)

Description

[Sue]

Attachment: MHz.png

[1.Description]:
[l12y][v2.1 & v2.2][FM Radio]Arabic: The words "MHz" on the main radio view is not translated in both Arabic language and Mirrored English language.
See attachment:MHz.png

[2.Testing Steps]: 
Prerequisite: Set system language as Arabic and insert a headset.
1. Tap on the "FM Radio" icon to open the FM Radio app. 
2. Look at "MHz" on the main radio view. 
3. Launch Settings -> Developer -> Enable Pseudo-localization.
4. Change system language as "Mirrored English".
5, Launch FM Radio again and observe the "MHz" on the main radio view.

[3.Expected Result]: 
2&5. "MHz" is translated properly without truncation. 

[4.Actual Result]: 
2&5. "MHz" is not translated.

[5.Reproduction build]: 
Device: Flame 2.1 (affected)
Build ID               20150415161202
Gaia Revision          bbe983b4e8bebfec26b3726b79568a22d667223c
Gaia Date              2015-04-09 13:52:48
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/c54aa1be51d6
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150415.193716
Firmware Date          Wed Apr 15 19:37:27 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 2.2 (affected)
Build ID               20150415162504
Gaia Revision          89a94a8b9c9087da916751697a61ba15bc0688c3
Gaia Date              2015-04-15 20:05:38
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/20e92b626530
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150415.195419
Firmware Date          Wed Apr 15 19:54:30 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
12237

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:

Hi - the issue here is actually a localizability issue that affects all locales, not just Arabic. Changing title to reflect this.
After doing some research within l10n team, Stas pointed out that MHz in Russian could be localized as МГц. This means this probably happens with other locales as well. 
I don't want us to block on this for 2.2 at this point since it's been like this in previous versions, but would like this to get in 3.0
thanks!

Comment 2

[Lancy(Leave from Mozilla)]

Attachment: Verify1_Flame2.1&2.2&3.0_all locales_Affected.png

Hi Delphine,
This issue can be reproduced on latest flame 2.1&2.2&3.0 user build in all locales, the "MHz" in FMRadio cannot be translated into corresponding language, could you help with this issue?
Thank you very much!

See attachment:Verify1_Flame2.1&2.2&3.0_all locales_Affected.png
Reproducing rate:10/10

Device: Flame 2.1 user build (Affected)
Build ID               20150517001201
Gaia Revision          c80865cb0bf73f1b97defbc646083b404feb3ac4
Gaia Date              2015-05-12 06:26:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/86182f8fc3f1
Gecko Version          34.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150517.040359
Firmware Date          Sun May 17 04:04:09 EDT 2015
Bootloader             L1TC000118D0


Device: Flame 2.2 user build (Affected)
Build ID               20150517002501
Gaia Revision          b388a235e89dab76c24323767cd87ebd7c4c8b17
Gaia Date              2015-05-15 16:08:41
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/54ae7c7182bc
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150517.041351
Firmware Date          Sun May 17 04:14:01 EDT 2015
Bootloader             L1TC000118D0


Device: Flame 3.0 user build (Affected)
Build ID               20150517010201
Gaia Revision          4c0f36e9dfe017bf2a698d416a57c8156b43383d
Gaia Date              2015-05-15 22:18:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2f6ea66057fe
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150517.043733
Firmware Date          Sun May 17 04:37:43 EDT 2015
Bootloader             L1TC000118D0

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Hema: are devs looking at all at these kinds of issues for 3.0 - or is v3 still uncertain enough that we should not be filing these kinds of issues? thanks

Comment 4

[Hema Koka [:hema]]

[Blocking Requested - why for this release]:

(In reply to Delphine Lebédel [:delphine - at l10n workweek until May 15 , slow to respond] from comment #3)
> Hema: are devs looking at all at these kinds of issues for 3.0 - or is v3
> still uncertain enough that we should not be filing these kinds of issues?
> thanks

Please file these kind of issues. This is probably something that has been like this since the beginning. 

Justin, when you get a chance fix this (Spark is higher priority though).

Thanks
Hema

Comment 5

[Dave Hylands [:dhylands]]

ne? drs to see if this needs to be spark+ or not.

Comment 6

[Doug Sherk (:drs) (inactive)]

We're not focusing on making everything localizable within Spark, so I would say that this definitely shouldn't be a spark+ blocker. Thanks for bringing it to my attention, anyways.

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

Can we consider to nominate this for 3.0 - in the case that this is still relevant in the upcoming release that we still don't know much about? thanks

Comment 8

[Hubert Figuiere [:hub]]

"MHz" is added by the CSS.

See
#frequency::after
div#fav-list-container div.fav-list-frequency::after

in fm.css

Comment 9

[GitHub Autolander Bot]

Attachment: [gaia] hfiguiere:bug1155099-fm-mhz-l10n > mozilla-b2g:master

Comment 10

[Hubert Figuiere [:hub]]

Comment on attachment 8656648 [details] [review]
[gaia] hfiguiere:bug1155099-fm-mhz-l10n > mozilla-b2g:master

Tim, you are still listed a module owner for FM Radio. Let me know if there is a better person to do review.

Gandalf, I'm new to the l20n stuff. If you have feedback on this corner case of localization, let me know.

Thanks,

Comment 11

[Hubert Figuiere [:hub]]

Comment on attachment 8656648 [details] [review]
[gaia] hfiguiere:bug1155099-fm-mhz-l10n > mozilla-b2g:master

Justin volunteered for the review.

Comment 12

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8656648 [details] [review]
[gaia] hfiguiere:bug1155099-fm-mhz-l10n > mozilla-b2g:master

LGTM. Thanks for addressing the re-localization case!

Comment 13

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/4bdc89cce08da73c1ed1a8ee0f66ef8286523865

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8656648 [details] [review]
[gaia] hfiguiere:bug1155099-fm-mhz-l10n > mozilla-b2g:master

Thanks for getting me in the loop! I was on PTO last week, so I'm glad you didn't wait and I believe that in such cases post-landing f/r make a lot of sense!

The patch looks good. I asked two questions in the PR because it seems to me that you should be able to just initialize the string "Mhz" inside the DOMLocalized callback and set the values there.
But nothing blocking :)

Comment 15

[Staś Małolepszy :stas]

Feel free to ni either me or Zibi on such requests.  I think there's might be a simpler way to handle this using L20n attributes.  Would you be interested in taking a new patch?

Comment 16

[Staś Małolepszy :stas]

FYI, we removed format() and replaced it with formatValue().  I updated the code in FM to make it work with this change: https://github.com/mozilla-b2g/gaia/commit/47459eead04385e22f967012b824f5abdddcfb7c

Comment 17

[Hubert Figuiere [:hub]]

But you no longer set the variable mhzString, which mean that it breaks when creation of a new "bookmark"

Comment 18

[Staś Małolepszy :stas]

The value of mhzString is given as the first argument of the callback function, isn't it?

Comment 19

[Staś Małolepszy :stas]

The breaking change has been reverted, I'm sorry for the trouble and skipping the review!  I'll file a new bug to fix this the right way.  :hub thanks for catching this so fast.

Comment 20

[Alissa（leave from Mozilla）]

Hi Staś,
Just a soft reminder, is there any update on this issue.
The words "MHz" on the main radio view is still not localizable on latest build of flamekk2.5 and master.

Device: Flamekk v2.5 512mb build [Affected]
Build ID               20151130173516
Device: Flamekk master 512mb build [Affected]
Build ID               20151130173516

Comment 21

[Staś Małolepszy :stas]

Alissa -- bug 1203509 should have fixed it.  What are the symptoms that you're seeing?