1155113 - Regression in rule-view: huge circle background appearing beneath rule when shorthand property is expanded

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

Attachment: rule-view-background.png

STR:
- Use FF40 (nightly, I was using a build of fx-team from this morning),
- Open the following URL: data:text/html,<div style="background:red">test</div>
- Open the inspector
- Select the <div> in the inspector
- In the rule-view sidebar, expand the background short-hand property name

Comment 1

[Patrick Brosset <:pbro>]

This comes from the ::before pseudo-element in the span.ruleview-colorswatch in the background-color long-hand property.
It seems like the .ruleview-swatch class is missing there:

.ruleview-swatch {
    cursor: pointer;
    border-radius: 50%;
    width: 1em;
    height: 1em;
    vertical-align: text-top;
    -moz-margin-end: 5px;
    display: inline-block;
    position: relative;
}

This was recently changed with bug 1055181.

Comment 2

[Patrick Brosset <:pbro>]

I think we just need to add the "ruleview-swatch" class here:
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/styleinspector/rule-view.js#2724

Mahdi, interested in tackling this small follow-up regression to bug 1055181?

Comment 3

[Mahdi Dibaiee [:mahdi][:mdibaiee]]

Attachment: Bug 1155113 - add ruleview-swatch class to expanded properties; r=pbrosset

I remember that I had actually encountered this when I was working on CSS Filter Tooltip but I couldn't reproduce it afterwards. Thanks Patrick!

Comment 5

[Matthew N. [:MattN]]

https://hg.mozilla.org/integration/fx-team/rev/008c5aebd9f9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/008c5aebd9f9

Comment 7

[Rezaul Huque Nayeem]

Successfully reproduce this bug on Firefox nightly 40.0a1 (2015-04-16)(20150416030209) as comment "0" on windows 7, 64 bit 

Found this bug fixed on latest beta 40.0 (20150730171029)

(Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:40.0) Gecko/20100101 Firefox/40.0)

Comment 8

[Nazir Ahmed Sabbir [:NaSb]]

Successfully reproduce the bug in Nightly 40.0a1 (2015-04-16) (Build ID: 20150416030209) on Linux x64

This Bug is now verified as fixed on Latest Firefox Beta 40.0b9

Build ID: 20150804131237
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0

As it is also verified on Windows (Comment 7), Marking it as verified!