1155170 - Add favicon to Hello link clicker page

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P3)

Comment 1

[Romain Testard [:RT]]

Winston, can you tell us what Favicon should be used on the Hello link clicker page? Hello logo or Firefox logo?

Comment 2

[:shell escalante]

will definitely take this small one once we have marketing graphic and the version to use

Comment 3

[Fabio Rios [:frios]]

Attachment: question-about-favicon.JPG

Romain, I'd like to help with this. Can you provide a bit more context about the favicon? I'm not sure what that means in terms of Hello.

Comment 4

[Romain Testard [:RT]]

There is currently no Favicon on Hello clicker pages - can you recommend a favicon we should be using (Hello logo VS Firefox logo?)?
See attached

Comment 5

[Romain Testard [:RT]]

Attachment: favicon.png

Comment 6

[Fabio Rios [:frios]]

Thank you. At this point in time we should have the Firefox logo there.

Comment 7

[Mark Banner (:standard8)]

Given comment 6, assuming feedback from Winston isn't required now.

Comment 8

[Mark Banner (:standard8)]

Attachment: Add favicon to Hello link clicker page. NPOTB DONTBUILD

Simple patch, this adds the current favicon from mozilla.org/firefox in the way that seems most appropraite for most browsers according to https://en.wikipedia.org/wiki/Favicon#File_format_support

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8609478 [details] [diff] [review]
Add favicon to Hello link clicker page. NPOTB DONTBUILD

Review of attachment 8609478 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9e1c4058ddd1

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9e1c4058ddd1