1155197 - ubi::Node implementation of jsObjectClassName is needlessly indirect

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

Attachment: For JS::ubi::Node, provide jsObjectClassName directly in JSObject specialization.

The specialization of jsObjectClassName for JS::ubi::Nodes that refer to JSObjects is needlessly indirect. The jsObjectClassName override can be placed directly in the specialization of JS::ubi::Concrete for JSObject.

(This change also fixes ASAN failures in combination with some other patches I have yet to land, but I'll be durned if I know why.)

Comment 1

[Jim Blandy :jimb]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5caad28a8a80

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8593373 [details] [diff] [review]
For JS::ubi::Node, provide jsObjectClassName directly in JSObject specialization.

Review of attachment 8593373 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, this was what I should have done originally.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e958fbf5cbbc

Comment 4

[Jim Blandy :jimb]

Here is a clean try push for that:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e827e9fa5d0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e958fbf5cbbc