1155228 - Awful blurry fonts in popup windows and menus after landing patch from bug #1150376

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Regression window (mozilla-inbound-win32)
Good:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1429128677/

Bad:
https://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32/1429129638/

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2a81e53f2624&tochange=dc3f816f39ce

Caused by:
Bug 1150376: Do not try to use D3D11 for popup windows. r=jrmuizel



[Tracking Requested - why for this release]: Regression

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: good1.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bad1.png

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: good2.png

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bad2.png

Comment 5

[timbugzilla]

I have seen this in today's nightly too (win32 build, Win 8.1 x64, All D2D1.1/DX11 stuff active, Nvidia GTX650, latest drivers).

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 40. 

Florin, can you have a look to see if this regression also affects 38 and 39 since we uplifted the patch in bug 1150376?   We may just end up backing out that patch.

Comment 7

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

This doesn't look "blurry" to me, it just looks like the text hinting is different.  Likely due to different rendering mechanism in use (no D2D/DWrite after the patch maybe?)

Comment 8

[Jeff Muizelaar [:jrmuizel]]

I talked to Bas about this. We're going to change this so that it only happens when using WARP.

Comment 9

[Bas Schouten (:bas.schouten)]

Attachment: Only use Basic OMTC when using WARP.

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

It seems that 38 and 39 are not affected by this issue.

Tested on Windows 7 64-bit with:
- latest Aurora, build ID: 20150416004008;
- Firefox 38 beta 5, build ID: 20150416143048.

Comment 11

[leichixian]

On my machine this issue is like some characters is "broken". Windows7 and firefox nightly v40 x64 edition.

Comment 12

[leichixian]

Attachment: Another situation of this issue

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84a83069abb5

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/84a83069abb5

Comment 15

[Sylvestre Ledru [:Sylvestre]]

Jeff, Bas, can we have an uplift request for this bug? (needed if we uplift 1150376)
Thanks

Comment 16

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8593559 [details] [diff] [review]
Only use Basic OMTC when using WARP.

Approval Request Comment
[Feature/regressing bug #]: 1150376
[User impact if declined]: Worse text rendering in popup menus
[Describe test coverage new/current, TreeHerder]: On trunk for a day or two
[Risks and why]: Low risk. We're just reverting to a path that that's already exercised.

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8593559 [details] [diff] [review]
Only use Basic OMTC when using WARP.

Should be in 38 beta 6.

Comment 18

[Cornel Ionce [:noni] [Hubs QA]]

Confirming this fix on Windows 7 64-bit using latest Firefox Nightly, build ID: 20150419030206.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a4e7361a2b5d

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4dc8d874746b