1155245 - The app status is not set correctly for hosted certified apps

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Antonio Manuel Amaya Calvo (:amac)]

STR: 
1. Enable developer mode (set 
pref("dom.apps.developer_mode", true);)
2. Boot and install any hosted app that is certified
3. Check the app status at /data/local/webapps/webapps.json

EXPECTED: 

The appStatus should be 3 (Certified)

ACTUAL:

The appStatus is 1. And if the app uses web components on any other thing that explicitly check for the status, it doesn't work.

Comment 1

[Antonio Manuel Amaya Calvo (:amac)]

Attachment: V1. Set the correct app status for hosted apps on developer mode

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8593435 [details] [diff] [review]
V1. Set the correct app status for hosted apps on developer mode

Review of attachment 8593435 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/Webapps.jsm
@@ +3107,5 @@
>      // don't update the permissions yet.
>      if (!aData.isPackage) {
>        if (supportUseCurrentProfile()) {
> +        // Until now we were not setting correctly the appStatus for hosted apps, and that didn't matter because
> +        // hosted apps couldn't be other than installed anyway. That's not true anymore...

Remove this comment. Historians will look at the blame & bugzilla.

Comment 3

[Antonio Manuel Amaya Calvo (:amac)]

Attachment: V2, with review comments adressed

r=fabrice

Try run at:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ae2d76e6200a

Comment 4

[Antonio Manuel Amaya Calvo (:amac)]

Test run looks (mostly) green, requesting checkin.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Your B2G/Mulet test failures look legit...
213 INFO TEST-UNEXPECTED-FAIL | dom/apps/tests/test_app_enabled.html | Test timed out. - expected PASS

Comment 6

[Antonio Manuel Amaya Calvo (:amac)]

Actually this kinda looks a lot like Bug 1115788. In fact, all of those tests seem to have a lot of oranges judging by the suggestions... The code added here only makes a single change if the developer_mode preference is true. And the only test where that's true is on test_install_dev_mode.html. So for all the rest, the code that's being executed is the same with and without this patch.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

The failures aren't happening in production, especially at the high frequency of your test run. Please post a green Try run to verify that your patch isn't at fault rather than asking me to accept it on faith and risk a tree closure if wrong.

Comment 8

[Antonio Manuel Amaya Calvo (:amac)]

Attachment: V3. Try-catched the lines to not fail if the preference doesn't exist

r=fabrice

Comment 9

[Antonio Manuel Amaya Calvo (:amac)]

Try run at: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b37fb308caa

Comment 10

[Antonio Manuel Amaya Calvo (:amac)]

And it's green... rerequesting checkin

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/83ce3822d127

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/83ce3822d127