TempAllocPolicy::pod_realloc() throws away your data on OOM

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jonco, Assigned: jonco)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 8593448 [details] [diff] [review]
temp-realloc-fix

Similar to bug 1154692.  If OOM occurs we retry the allocation -- but we don't copy the caller's data.

This is a fix, but I'm thinking we should rewrite onOutOfMemory() to have a clearer interface.
Attachment #8593448 - Flags: review?(terrence)
Comment on attachment 8593448 [details] [diff] [review]
temp-realloc-fix

Review of attachment 8593448 [details] [diff] [review]:
-----------------------------------------------------------------

I think there's already a bug open to rewrite all of this.

Thanks for making the spot fixes in the meantime!
Attachment #8593448 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/07c36315c3f2
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.