Closed
Bug 1155268
Opened 9 years ago
Closed 9 years ago
Remove static_cast added in bustage fix for bug 1154805
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(2 files)
5.13 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
1.23 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
In bug 1154805, I had bustage issues because cpearce added usage of MediaTaskQueue::GetCurrentQueue right next to my patch that moves that functionality to AbstractThread. I changed the call and added a static_cast, but that's not really ideal. We should either pass the MediaTaskQueue explicitly or convert the members to AbstractThread.
Comment 2•9 years ago
|
||
The EMEDecryptor::mTaskQueue can probably be AbstractThreads. We'd also need to change SamplesWaitingForKeys. Long term, we're better off moving towards using AbstractThreads and obscuring its implemententation of MediaTaskQueue's right?
Flags: needinfo?(cpearce)
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Chris Pearce (:cpearce) from comment #2) > Long term, we're better off moving towards using AbstractThreads and > obscuring its implemententation of MediaTaskQueue's right? Hm. I've pondered over this and am having trouble convincing myself that there's a lot of value in doing this. Assuming that we don't have any plans to make this code run on other sorts of thread, the extra abstraction just makes the mechanics and invariants of the code less clear. So think we should just implement the proper checking. I'll attach a patch.
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8594739 -
Flags: review?(cpearce)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8594740 -
Flags: review?(cpearce)
Assignee | ||
Comment 6•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=491a78031712
Updated•9 years ago
|
Attachment #8594739 -
Flags: review?(cpearce) → review+
Updated•9 years ago
|
Attachment #8594740 -
Flags: review?(cpearce) → review+
Assignee | ||
Comment 7•9 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/95d49a751ed4 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/92ca25231787
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/95d49a751ed4 https://hg.mozilla.org/mozilla-central/rev/92ca25231787
Assignee: nobody → bobbyholley
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•