Closed Bug 1155268 Opened 6 years ago Closed 6 years ago

Remove static_cast added in bustage fix for bug 1154805

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(2 files)

In bug 1154805, I had bustage issues because cpearce added usage of MediaTaskQueue::GetCurrentQueue right next to my patch that moves that functionality to AbstractThread.

I changed the call and added a static_cast, but that's not really ideal. We should either pass the MediaTaskQueue explicitly or convert the members to AbstractThread.
Chris, do you have a preference here?
Flags: needinfo?(cpearce)
The EMEDecryptor::mTaskQueue can probably be AbstractThreads. We'd also need to change SamplesWaitingForKeys.

Long term, we're better off moving towards using AbstractThreads and obscuring its implemententation of MediaTaskQueue's right?
Flags: needinfo?(cpearce)
(In reply to Chris Pearce (:cpearce) from comment #2)
> Long term, we're better off moving towards using AbstractThreads and
> obscuring its implemententation of MediaTaskQueue's right?

Hm. I've pondered over this and am having trouble convincing myself that there's a lot of value in doing this. Assuming that we don't have any plans to make this code run on other sorts of thread, the extra abstraction just makes the mechanics and invariants of the code less clear. So think we should just implement the proper checking. I'll attach a patch.
Attachment #8594739 - Flags: review?(cpearce) → review+
Attachment #8594740 - Flags: review?(cpearce) → review+
https://hg.mozilla.org/mozilla-central/rev/95d49a751ed4
https://hg.mozilla.org/mozilla-central/rev/92ca25231787
Assignee: nobody → bobbyholley
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.