In bug 1154805, I had bustage issues because cpearce added usage of MediaTaskQueue::GetCurrentQueue right next to my patch that moves that functionality to AbstractThread. I changed the call and added a static_cast, but that's not really ideal. We should either pass the MediaTaskQueue explicitly or convert the members to AbstractThread.
Chris, do you have a preference here?
The EMEDecryptor::mTaskQueue can probably be AbstractThreads. We'd also need to change SamplesWaitingForKeys. Long term, we're better off moving towards using AbstractThreads and obscuring its implemententation of MediaTaskQueue's right?
(In reply to Chris Pearce (:cpearce) from comment #2) > Long term, we're better off moving towards using AbstractThreads and > obscuring its implemententation of MediaTaskQueue's right? Hm. I've pondered over this and am having trouble convincing myself that there's a lot of value in doing this. Assuming that we don't have any plans to make this code run on other sorts of thread, the extra abstraction just makes the mechanics and invariants of the code less clear. So think we should just implement the proper checking. I'll attach a patch.
Attachment #8594739 - Flags: review?(cpearce) → review+
Attachment #8594740 - Flags: review?(cpearce) → review+
You need to log in before you can comment on or make changes to this bug.