remove XULAPP_DEFINES from DIST_FILES_FLAGS

RESOLVED FIXED in Firefox 40

Status

Firefox Build System
General
RESOLVED FIXED
3 years ago
4 months ago

People

(Reporter: froydnj, Unassigned)

Tracking

unspecified
mozilla40
Dependency tree / graph

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
DIST_FILES would be (sort-of) manifest-installable, except that we add XULAPP_DEFINES to PP_FLAGS when we process them.

XULAPP_DEFINES is only used by one (!) thing in this way, some debug QA addon in comm-central.  Filing a separate bug for that.
(Reporter)

Updated

3 years ago
Depends on: 1155290
(Reporter)

Comment 1

3 years ago
Created attachment 8602747 [details] [diff] [review]
remove XULAPP_DEFINES from DIST_FILES_FLAGS

Nothing uses XULAPP_DEFINES anymore, let's just get rid of it.  There
are plenty more places to add in defines for DIST_FILES if one is so
inclined.
Attachment #8602747 - Flags: review?(mshal)

Updated

3 years ago
Attachment #8602747 - Flags: review?(mshal) → review+

Comment 3

3 years ago
Both DOM Inspector and Chatzilla extensions still use XULAPP_DEFINES
I have started looking at DOMi but Chatzilla seems to be more complicated.

Updated

3 years ago
Depends on: 1162694

Updated

3 years ago
Depends on: 1162695
(Reporter)

Comment 4

3 years ago
Are Chatzilla and DOMi built as part of SeaMonkey?  I am confused why these extensions matter otherwise.
Flags: needinfo?(iann_bugzilla)

Comment 5

3 years ago
Yes, they are.
Flags: needinfo?(iann_bugzilla)
(Reporter)

Comment 6

3 years ago
Do they live in their own separate repositories outside of comm-central?

Comment 7

3 years ago
(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #6)
> Do they live in their own separate repositories outside of comm-central?

Yes, they have their own repos.
Could they use XULPPFLAGS instead?

Comment 9

3 years ago
(In reply to Ian Neal from comment #3)
> Both DOM Inspector and Chatzilla extensions still use XULAPP_DEFINES
> I have started looking at DOMi but Chatzilla seems to be more complicated.
Patches for both have now landed.
(Reporter)

Comment 10

3 years ago
(In reply to Ian Neal from comment #9)
> (In reply to Ian Neal from comment #3)
> > Both DOM Inspector and Chatzilla extensions still use XULAPP_DEFINES
> > I have started looking at DOMi but Chatzilla seems to be more complicated.
> Patches for both have now landed.

Thank you!
https://hg.mozilla.org/mozilla-central/rev/f171cc700c5d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

Updated

4 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.