Closed Bug 1155283 Opened 9 years ago Closed 9 years ago

remove XULAPP_DEFINES from DIST_FILES_FLAGS

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: froydnj, Unassigned)

References

Details

Attachments

(1 file)

DIST_FILES would be (sort-of) manifest-installable, except that we add XULAPP_DEFINES to PP_FLAGS when we process them.

XULAPP_DEFINES is only used by one (!) thing in this way, some debug QA addon in comm-central.  Filing a separate bug for that.
Depends on: 1155290
Nothing uses XULAPP_DEFINES anymore, let's just get rid of it.  There
are plenty more places to add in defines for DIST_FILES if one is so
inclined.
Attachment #8602747 - Flags: review?(mshal)
Attachment #8602747 - Flags: review?(mshal) → review+
Both DOM Inspector and Chatzilla extensions still use XULAPP_DEFINES
I have started looking at DOMi but Chatzilla seems to be more complicated.
Depends on: 1162694
Depends on: 1162695
Are Chatzilla and DOMi built as part of SeaMonkey?  I am confused why these extensions matter otherwise.
Flags: needinfo?(iann_bugzilla)
Yes, they are.
Flags: needinfo?(iann_bugzilla)
Do they live in their own separate repositories outside of comm-central?
(In reply to Nathan Froyd [:froydnj] [:nfroyd] from comment #6)
> Do they live in their own separate repositories outside of comm-central?

Yes, they have their own repos.
Could they use XULPPFLAGS instead?
(In reply to Ian Neal from comment #3)
> Both DOM Inspector and Chatzilla extensions still use XULAPP_DEFINES
> I have started looking at DOMi but Chatzilla seems to be more complicated.
Patches for both have now landed.
(In reply to Ian Neal from comment #9)
> (In reply to Ian Neal from comment #3)
> > Both DOM Inspector and Chatzilla extensions still use XULAPP_DEFINES
> > I have started looking at DOMi but Chatzilla seems to be more complicated.
> Patches for both have now landed.

Thank you!
https://hg.mozilla.org/mozilla-central/rev/f171cc700c5d
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.