1155319 - Integrate Filter: signature link into Job name: field to save space

Status: VERIFIED FIXED

(Tree Management :: Treeherder, enhancement, P4)

Description

[Jonathan French (:jfrench)]

Discussed with camd in channel, perhaps we might integrate the new Filter: (signature) job details line as an icon prefix, or suffix to the existing Job name: field, to save a line.

Eg.

(very compact)
Job name[fa-external-link]: (current job name string..)

(pretty compact)
Job name: (current job name string...) [3a3e3a9]


Or, if we kept it as-is, perhaps we might just update the line like this to be:

Signature: 3a3e3a9

So there's a varying signature value visible, instead of always saying 'signature' in each job.

Just some ideas :)

Comment 1

[Jonathan French (:jfrench)]

Attachment: currentVsProposed

Here's a screen grab of our current 2 rows, vs. a proposed 1 row. It tries to provide reasonable mouse target areas for each by separating them with the " :" of the Job label.

Comment 2

[Jonathan French (:jfrench)]

Attachment: jobFieldTitlesProposed

And here's the hover titles for each field in the Job row.

Comment 3

[Jonathan French (:jfrench)]

Adding folks to see what they think of the proposed screen grabs.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Fine by me.

FWIW, we could also save some space by removing redundant info from the job string, i.e. "B2G ICS Emulator debug Mochitest M Mochitest 13"

Comment 5

[Cameron Dawson [:camd]]

Looks good to me.  :)

Comment 6

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#487

Please see above PR for status and review.

Camd if you can just do the review, that's great. Wes and I chatted in channel last week and I want to make sure the target area in the screen grabs is ok for him also. If so, I'll merge after.

Comment 7

[Jonathan French (:jfrench)]

I checked in with Wes and he's cool with the implementation. If we decide we want to tighten up the spacing we can remove the superscript fa-pencil "signature" icon later, if need be.

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/edb92da624d3bc45baa408b9c5973d956d64fa1c
Bug 1155319 - Integrate signature into Job field to save space

Comment 9

[Jonathan French (:jfrench)]

Marking fixed per above merge. I will verify on the next push to stage/prod.

Comment 10

[Jonathan French (:jfrench)]

Verified fixed in production. If anyone isn't a fan of the fa-open-pencil icon, let me know and I can remove it.

Comment 11

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/51bd8abba74c9b6fab715caaeac8aee951cbb82c
Bug 1155319 - Integrate signature into Job field to save space