115532 - [FIX]background images not saving for 'Save Page as web page complete'

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P2)

Description

[benjamin mooney]

background images are not being saved, and are not recognised in source for the
save as web page complete.

<td height="70" background="../image/new/tile.jpg">
<img border="0"
src="Build%20Comments%20-%20MozillaZine%21%20Your%20Source%20for%20Mozilla%20News%20and%20Advocacy_files/title.gif"
width="180" height="70" align="left" alt="mozillaZine">

"Build%20Comments%20-%20MozillaZine%21%20Your%20Source%20for%20Mozilla%20News%20and%20Advocacy_files"
is the directory created for all images to be saved into, this dosent happen for
background images.

Comment 1

[[not reading bugmail]]

see bug 11632 comment 85.. dont know if this was suppose to be added in.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Duplicate of "table/cell backgrounds not saved with save complete"

*** This bug has been marked as a duplicate of 115107 ***

Comment 3

[Adam Lock]

Also note there is no such attribute as "background" on the TD tag. Perhaps
Mozilla is honouring this in quirks mode, but my persistence code isn't at the
moment.

Comment 4

[Boris Zbarsky [:bzbarsky]]

While there is no background attr in HTML4, we _do_ support it and it's widely
used... I think we should persist these backgrounds.

Comment 5

[Boris Zbarsky [:bzbarsky]]

taking bug.  Adam, let me know if you feel we really should not do this sometime
in the next few days, ok?

Comment 6

[Adam Lock]

If it's a widely supported quirk then yes I agree we should add support for it.
The standard nsIDOMHTMLTable* interfaces do not have a background attribute so
the patch would have to pull it out using the nsIDOMElement/nsIDOMNode interfaces.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Yeah... backgrounds on table/tr/td are fairly common, unfortunately.

As the target suggests, I'm not getting to this any time soon, so feel free to
take if you're going to have time before 1.0 for it.  :)

Comment 8

[Boris Zbarsky [:bzbarsky]]

1.1alpha is frozen.  Unsetting milestone and will retriage in a few days when I
can make a realistic assessment of the situation.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 10

[Boris Zbarsky [:bzbarsky]]

Oh, the irrelevant stuff in there is compile warning fixes.

Comment 11

[Adam Lock]

Comment on attachment 88566 [details] [diff] [review]
Proposed fix

You're missing the code to
nsWebBrowserPersist::CloneNodeWithFixedUpURIAttributes to fix up the background
attribute with the new file location.

Without it, the background will be saved but the document will still point to
the original one.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: Doh. That makes sense...

Comment 13

[Adam Lock]

Comment on attachment 88622 [details] [diff] [review]
Doh.  That makes sense...

r=adamlock

Comment 14

[Johnny Stenback (:jst)]

Comment on attachment 88622 [details] [diff] [review]
Doh.  That makes sense...

sr=jst

Comment 15

[Boris Zbarsky [:bzbarsky]]

fixed on trunk