1155321 - Job name in job details is getting incorrectly parsed on stage

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Jonathan French (:jfrench)]

Currently on stage with latest master changes, the Job name: field is getting incorrectly parsed. For example:

Production:
Linux mozilla-central build

Stage:
Linux opt unknown ? Build B

Camd mentioned it may be a side effect of a recent change, so assigning per his request.

Comment 1

[Ed Morley [:emorley]]

P1 since blocking the prod push :-)

Comment 2

[Cameron Dawson [:camd]]

Ahh, this has to do if a job does not belong to a job group.  I'll just remove that from the string.

Comment 3

[Cameron Dawson [:camd]]

Attachment: fix ungrouped job filter params

Comment 4

[Ed Morley [:emorley]]

Comment on attachment 8594212 [details] [review]
fix ungrouped job filter params

lgtm with the nit fixed, thank you :-)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/9948920784e9f3fffd0caf4f6afe714c6c9b8581
Bug 1155321 - fix filter params for jobs not in a group

If a job (like a build) is not in a group, then the job details string
for filtering by fields showed “unknown ?” as the job-group name and
symbol.  Those are legitimate values internally, but the user shouldn’t
see them.

Comment 6

[Cameron Dawson [:camd]]

Fixed the nit and merged.  :)  Thanks for the late-night review.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/e4307ba3d3d636c4679cd1c6508b3b9acf79e6a1
Bug 1155321 - fix filter params for jobs not in a group

If a job (like a build) is not in a group, then the job details string
for filtering by fields showed “unknown ?” as the job-group name and
symbol.  Those are legitimate values internally, but the user shouldn’t
see them.