Closed Bug 1155352 Opened 9 years ago Closed 9 years ago

[e10s] Fix browser_middleMouse_noJSPaste.js

Categories

(Firefox :: General, defect)

defect
Not set
normal
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 40
Iteration:
40.2 - 27 Apr
Tracking Status
e10s + ---
firefox40 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

Details

Attachments

(1 file)

      No description provided.
Iteration: --- → 40.2 - 27 Apr
Points: --- → 1
Attachment #8593554 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8593554 [details] [diff] [review]
Fix and re-enable browser_middleMouse_noJSPaste.js

Review of attachment 8593554 [details] [diff] [review]:
-----------------------------------------------------------------

r=me assuming green try

::: browser/base/content/test/general/browser_middleMouse_noJSPaste.js
@@ +14,5 @@
> +    SimpleTest.waitForClipboard(url, () => {
> +      Components.classes["@mozilla.org/widget/clipboardhelper;1"]
> +                .getService(Components.interfaces.nsIClipboardHelper)
> +                .copyString(url, document);
> +    }, resolve);

Can we add reject as another callback here for the timed out / failed case (and an ok(false, ...) with a message to clarify what happened) ?
Attachment #8593554 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/fa9178ca5dc2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: