Closed Bug 1155355 Opened 5 years ago Closed 5 years ago

[e10s] Re-enable and fix layout/xul/test tests

Categories

(Core :: General, defect)

defect
Not set
Points:
2

Tracking

()

RESOLVED FIXED
mozilla40
Iteration:
40.2 - 27 Apr
Tracking Status
e10s + ---
firefox40 --- fixed

People

(Reporter: enndeakin, Assigned: enndeakin)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Three tests are disabled.

This patch reworks them to use BrowserTestUtils functions.

Two real fixes were needed:
 - the browser.js change because normal tooltips from nsXULTooltipListener ignore mouse events while a drag is occurring. This change adds similar support here.
 - need to use system event listeners so that stopPropagation in a child doesn't block the tooltip from appearing.
Iteration: --- → 40.2 - 27 Apr
Points: --- → 2
Comment on attachment 8593557 [details] [diff] [review]
browser_layoutxul

These are all tooltip related tests.
Attachment #8593557 - Flags: review?(wmccloskey)
Comment on attachment 8593557 [details] [diff] [review]
browser_layoutxul

Review of attachment 8593557 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: layout/xul/test/browser_bug685470.js
@@ +1,2 @@
> +add_task(function* () {
> +  const url = "<p id=\"p1\" title=\"tooltip is here\">This paragraph has a tooltip.</p>";

Maybe call this "html" or something instead of url.

::: layout/xul/test/browser_bug703210.js
@@ +15,2 @@
>  
> +  yield BrowserTestUtils.synthesizeMouseAtCenter("#p2", { type: "mousemove" }, browser);

Is this initial mousemove just to ensure that any existing tooltip is hidden? If so, please comment.
Attachment #8593557 - Flags: review?(wmccloskey) → review+
Blocks: e10s-tests
tracking-e10s: --- → +
https://hg.mozilla.org/mozilla-central/rev/c36ce7aed6d9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.