1155411 - [Aries] logshake doesn't trigger when hitting power + volume up

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. install bugzilla lite staging client : via https://bzlite-staging.herokuapp.com/install.html
2. log into bugzilla lite
3. tap power+ volume up

Expected: logshake triggers and attaches
Actual: nothing happens, if you hold it too long then the device shuts down.

Comment 1

[Dale Harvey (:daleharvey)]

Is this a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=1155587? Is "shake to save system log" working or anything in the logs?

Comment 2

[Dale Harvey (:daleharvey)]

hrm, updated my build on the dogfood device and not getting logs triggered, the code seems up to date but not actually running, very confusing

Comment 3

[Dale Harvey (:daleharvey)]

This works on a fresh flash on the flame

Comment 4

[Dale Harvey (:daleharvey)]

Ok this is due to lightsaber gaia branch being out of date - https://github.com/mozilla-b2g/gaia/blob/lightsaber/apps/system/js/hardware_buttons.js

If you can reproduce this on a fresh master build then please reopen, but I cant reproduce any issue on m-c / master

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Um.  It's still not working.

Comment 6

[Dale Harvey (:daleharvey)]

Hrm this has been working fine for me since it landed, if I flash a central eng build on a flame this works as soon as the device boots. Is there anything special with your build that may cause this not to work? (maybe try removing the usb just in case)

Comment 7

[Dale Harvey (:daleharvey)]

And can you enable "shake to save logs" in the developer menu and see if that works as well? cheers

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

It doesn't seem to work on Aries.  It works fine on flame.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: logcat.txt

I'm not sure how cypress is getting updated:
changeset:   240170:bbf9c19421b4

I had updated manually on the side before building and flashing.

attached is the logcat when I try to do the power+volume up

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I should clarify what doesn't work on Aries.  The logshake and shaking the device works on both flame and Aries.  The power+volume up does work on Flame.

The Power+volume up does not work on Aries.

Comment 11

[Doug Sherk (:drs) (inactive)]

Maybe we should start posting the device that a bug repros on in the first comment.

Comment 12

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

that's true.  I should start comparing aries versus flame since there seems to be differences.

Having said that, I recall in a different kernel they had to define the key strokes for it to function at the kernel level:
https://git.mozilla.org/?p=external/sprd-aosp/u-boot.git;a=commitdiff;h=f622abe55d61181554ae2b9d2fe2a728b1583828;hp=37c1ba6741cdad6b5712eb8608c894ff6629a73c

Do we have to do a similar situation here using sysrq?  Not sure if flame went through the same thing or not...

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I updated my cypress as cypress got updated, and I still can reproduce this issue.

Comment 14

[Dale Harvey (:daleharvey)]

Ok thanks, been avoiding debugging this on aries since I dont want to break my dogfood device, but will take a look

Comment 15

[Dale Harvey (:daleharvey)]

ok reproduced on aries, the events are being triggered on Aries are definitely different to what is expected by the hardware buttons fsm

Aries:

Press volumeup then sleep
I/GeckoConsole(  317): Content JS LOG: evt: volume-up-button-press
I/GeckoConsole(  317): Content JS LOG: volume state entered
I/GeckoConsole(  317): Content JS LOG: evt: undefined
I/GeckoConsole(  317): Content JS LOG: evt: undefined
I/GeckoConsole(  317): Content JS LOG: evt: volume-up-button-release

Press sleep then volumeup
I/GeckoConsole(  317): Content JS LOG: evt: sleep-button-press
I/GeckoConsole(  317): Content JS LOG: sleep state entered
I/GeckoConsole(  317): Content JS LOG: evt: undefined
I/GeckoConsole(  317): Content JS LOG: evt: sleep-button-release
I/GeckoConsole(  317): Content JS LOG: evt: undefined
I/GeckoConsole(  317): Content JS LOG: evt: undefined
I/GeckoConsole(  317): Content JS LOG: evt: undefined
I/GeckoConsole(  317): Content JS LOG: evt: volume-up-button-press
I/GeckoConsole(  317): Content JS LOG: evt: sleep-button-press
I/GeckoConsole(  317): Content JS LOG: sleep button press in volume state
I/GeckoConsole(  317): Content JS LOG: evt: undefined
(if you hold long enough the device will turn off)

Flame: 

Press volumeup then sleep
I/GeckoConsole(30968): Content JS LOG: evt: volume-up-button-press
I/GeckoConsole(30968): Content JS LOG: volume state entered
I/GeckoConsole(30968): Content JS LOG: evt: sleep-button-press
I/GeckoConsole(30968): Content JS LOG: sleep button press in volume state
I/GeckoConsole(30968): Content JS LOG: evt: undefined
I/GeckoConsole(30968): Content JS LOG: SENDING SYSTEM LOG


Press sleep then volumeup
I/GeckoConsole(30968): Content JS LOG: evt: sleep-button-press
I/GeckoConsole(30968): Content JS LOG: entering sleep state
I/GeckoConsole(30968): Content JS LOG: evt: undefined
I/GeckoConsole(30968): Content JS LOG: evt: undefined
I/GeckoConsole(30968): Content JS LOG: evt: undefined
I/GeckoConsole(30968): Content JS LOG: evt: volume-up-button-press
I/GeckoConsole(30968): Content JS LOG: volumeup button press
I/GeckoConsole(30968): Content JS LOG: SENDING SYSTEM LOG

Comment 16

[Dale Harvey (:daleharvey)]

Originally assumed there was some type of issue with concurrrent hardware key presses, however strangely screenshot works absolutely fine. Heres a similiar log for screenshots - https://gist.github.com/daleharvey/f3bedd82533dac08e1ae

It seems somewhere in gonk volumeup must be handled specially as they are hitting the system app in a completely different order, fairly sure this is going to need fixing by someone who can take a look at the gonk level.

Comment 17

[:gerard-majax]

Multiple docs are referring to this key combo on several devices from the Xperia Z family as the "shutdown combo". Indeed, it has the exact same behavior as long-pressing the yellow button next to the SIM card to perform a shutdown.

I'm not sure we can find a solution other than using another key combo.

Comment 18

[:gerard-majax]

We could use Power+Camera (and not MozCameraFocusAdjust) for this.

Comment 19

[Dale Harvey (:daleharvey)]

23:13 <gerard-majax> daleharvey, https://pastebin.mozilla.org/8832114
23:13 <gerard-majax> 74 is power
23:13 <gerard-majax> 72 is voldown
23:13 <gerard-majax> 73 is volup
23:14 <gerard-majax> daleharvey, when you hold volup + power for long, it vibrates
23:14 <gerard-majax> exactly like when you long press the small yellow button next to SIM card 
23:14 <gerard-majax> daleharvey, and same on my android device
23:15 <gerard-majax> I would deduce it's a combo we cannot use there at all :)

Taking again, so it looks like z3c has an in built firmware shortcut for volumeup + power to turn off the device when the software is broken. This means on the z3c we cannot use this shortcut in gaia (it works fine on other devices, although possibly not all)

So we need to come up with a new trigger for this :(

Comment 20

[Dale Harvey (:daleharvey)]

I can test out Power+Camera, but worth remembering most other devices, at least the flame dont have a camera button, using 2 shortcuts is probably fine but need to take into account for https://bugzilla.mozilla.org/show_bug.cgi?id=1155719

Comment 21

[Dale Harvey (:daleharvey)]

It looks like the android shortcut for this is Volume up + Volume down + power, however we will likely run into the same issue with that plus its fairly hard to actually do on the z3c.

Another option may be volumeup + volumedown

Comment 22

[GitHub Autolander Bot]

Attachment: [gaia] daleharvey:1155411 > mozilla-b2g:master

Comment 23

[Dale Harvey (:daleharvey)]

Comment on attachment 8601459 [details] [review]
[gaia] daleharvey:1155411 > mozilla-b2g:master

Ok so this works on the flame + aries, I cant see references to the shortcut being used in other androids and is relatively easy to trigger.

Comment 24

[:gerard-majax]

Comment on attachment 8601459 [details] [review]
[gaia] daleharvey:1155411 > mozilla-b2g:master

Looks good to me and it works on my device too :)

Comment 25

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8601459 [details] [review]
[gaia] daleharvey:1155411 > mozilla-b2g:master

Looks good

Comment 26

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/426fe6450ab8da92bb473fef12ccb39c6c920dd0

Comment 27

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified with build : 
https://tools.taskcluster.net/task-inspector/#xRVy3KtOQdKKP1gu0quJIw/0

use of volume up and down key together.