1155418 - Preview of images are just overlayed on top, which could confuse some people.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bugzilla Lite, defect, P1)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. install bugzilla lite staging client : via https://bzlite-staging.herokuapp.com/install.html
2. log into bugzilla lite
3. tap add an attachment
4 [review]. add an image
5. select done.
6. tap the image

Expected: some header or something explaining that this is a preview of the image and option to go back or remove
Actual: no header nor option; image is overlayed and you can see a "logout" link in portrait which you can't invoke.

Comment 1

[Dale Harvey (:daleharvey)]

I would like to switch the behaviour of the attachments to mimic the behaviour of the attachments in the email application, they trigger a 'view' activity which when invoked will bring up the gallery etc, this will allow us to preview much more files and be far cleaner on our implementation, sound good?

Comment 2

[Jacqueline Savory [:jsavory] UX]

Yup I agree, this is what I would recommend as well. Following the email format works for me, let me know if there is anything you want me to make specs for.

Comment 3

[James Hobin [:hobinjk]]

Attachment: Github PR

I haven't actually had an opportunity to test this because I don't have an account on bugzilla-dev. It's a relatively straightforward series of changes, but promises are difficult and bugs are sneaky.

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8624406 [details] [review]
Github PR

Hey James, this looks great thanks a lot. 

There is one issue, mozActivity isnt supported on desktop and we want bzlite to be working there. We need to detect mozActivity support and either use <a href="data:..."> or window.open if mozActivity doesnt exist

Comment 5

[Dale Harvey (:daleharvey)]

I have cleared review for now but ill give it a few run throughs to test its all working good, code wise its looking great, nice cleanups and better performance lazy encoding the blobs. I am trying to figure out how to get a global login for bugzilla-dev so its easier to test

Comment 6

[Dale Harvey (:daleharvey)]

James, asked #bmo for a global login so anyone contributing to bzlite can use these credentials to test

https://github.com/mozilla-b2g/bzlite#running-bugzilla-lite

Hopefully that helps you out, cheers

Comment 7

[James Hobin [:hobinjk]]

(In reply to Dale Harvey (:daleharvey) from comment #6)
> James, asked #bmo for a global login so anyone contributing to bzlite can
> use these credentials to test
> 
> https://github.com/mozilla-b2g/bzlite#running-bugzilla-lite
> 
> Hopefully that helps you out, cheers

Thanks! I've verified that my change works on the Flame and Firefox Nightly. It now falls back to using URL.createObjectURL when MozActivity is unavailable. This technically brings the minimum supported browser version up slightly, but is much cleaner than creating a base64 encoding.

The pull request has been updated accordingly, I'll add back the review flag.

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 8624406 [details] [review]
Github PR

Yeh I am not super worried about older desktop browsers but hoping to keep it working in latest chrome and firefox at least

Thanks a lot, this is great and its working well for me

Comment 9

[Dale Harvey (:daleharvey)]

Merged in https://github.com/mozilla-b2g/bzlite/commit/75024f10209d2696555fba72d6cb4c1b50ca2f1e