1155433 - Provide mechanism for MediaTaskQueue/AbstractThread tasks to be cancelable

Status: RESOLVED INACTIVE

(Core :: Audio/Video: Playback, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

In the MediaDataDecoder::Input implementations, it's common to dispatch a task to another task queue (the "video" or "audio" task queue owned by the MP4Reader) to process the input on the other task queue using synchronous platform APIs. This is so that we don't block the decode task queue when we make a platform's synchronous decoder conform to the async MediaDataDecoder API.

The problem here is that when we want to implement MediaDataDecoder::Flush(), we want to cancel any pending tasks to process the input samples, as we don't want to waste time processing input samples that we don't need to output.

(A side problem is that MediaDataDecoder::Flush() is supposed to be synchronous, i.e. block until the flush is complete and we can guarantee that no more output will be returned. Really MediaDataDecoder::Flush() should return a promise, but that's a bigger change.)

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Bobby volunteered to apply his mental superpowers to this issue.

Comment 2

[Bobby Holley (:bholley)]

Note - we should convert the use-case from bug 1145052 to this infrastructure.

Comment 3

[Bobby Holley (:bholley)]

This is on my list, but no particular reason to leave it NI.

Comment 4

[Nils Ohlmeier [:drno]]

Mass closing do to inactivity.
Feel free to re-open if still needed.