1155468 - Unable to compile js 32-bit ARM-simulator shells on Mac

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: compilation error

I hit a compile failure when compiling js 32-bit ARM-simulator shell on m-c rev a4650f2e28a2.

LD=ld CROSS_COMPILE=1 CC="clang -Qunused-arguments -msse2 -mfpmath=sse -arch i386" RANLIB=ranlib CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments -msse2 -mfpmath=sse" AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213 HOST_CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse" sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-arm-simulator --enable-debug --enable-optimize --enable-nspr-build --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

===

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/a4650f2e28a2
user:        Nicolas B. Pierron
date:        Mon Apr 13 16:31:15 2015 +0200
summary:     Bug 1135629 - Rename Register::code to Register::encoding for Assembler functions. r=jandem

Nicolas, is bug 1135629 a likely regressor? This blocks fuzzing 32-bit ARM simulator builds on Mac.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Let me know if a more comprehensive log is needed.

Comment 2

[Nicolas B. Pierron [:nbp]]

I don't know why we did not caught that on treeherder.
I will fix that.

Comment 3

[Nicolas B. Pierron [:nbp]]

Attachment: Fix Register::GetName typedef issue with clang.

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Comment on attachment 8593918 [details] [diff] [review]
Fix Register::GetName typedef issue with clang.

This fixes the issue. Thanks! :)

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Helped to land this blocker:

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb25e0475da5

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cb25e0475da5