Unable to compile js 32-bit ARM-simulator shells on Mac

RESOLVED FIXED in Firefox 40

Status

()

--
blocker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gkw, Assigned: nbp)

Tracking

({regression})

Trunk
mozilla40
x86
macOS
regression
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [fuzzblocker])

Attachments

(2 attachments)

(Reporter)

Description

4 years ago
Created attachment 8593684 [details]
compilation error

I hit a compile failure when compiling js 32-bit ARM-simulator shell on m-c rev a4650f2e28a2.

LD=ld CROSS_COMPILE=1 CC="clang -Qunused-arguments -msse2 -mfpmath=sse -arch i386" RANLIB=ranlib CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse -arch i386" AS=$CC AR=ar STRIP="strip -x -S" HOST_CC="clang -Qunused-arguments -msse2 -mfpmath=sse" AUTOCONF=/usr/local/Cellar/autoconf213/2.13/bin/autoconf213 HOST_CXX="clang++ -Qunused-arguments -msse2 -mfpmath=sse" sh /Users/skywalker/trees/mozilla-central/js/src/configure --target=i386-apple-darwin9.2.0 --enable-macos-target=10.5 --enable-arm-simulator --enable-debug --enable-optimize --enable-nspr-build --enable-more-deterministic --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

===

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/a4650f2e28a2
user:        Nicolas B. Pierron
date:        Mon Apr 13 16:31:15 2015 +0200
summary:     Bug 1135629 - Rename Register::code to Register::encoding for Assembler functions. r=jandem

Nicolas, is bug 1135629 a likely regressor? This blocks fuzzing 32-bit ARM simulator builds on Mac.
Flags: needinfo?(nicolas.b.pierron)
(Reporter)

Comment 1

4 years ago
Let me know if a more comprehensive log is needed.
(Assignee)

Comment 2

4 years ago
I don't know why we did not caught that on treeherder.
I will fix that.
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Created attachment 8593918 [details] [diff] [review]
Fix Register::GetName typedef issue with clang.
Attachment #8593918 - Flags: review?(jdemooij)
(Assignee)

Updated

4 years ago
Flags: needinfo?(nicolas.b.pierron)
Attachment #8593918 - Flags: feedback?(gary)
(Reporter)

Comment 4

4 years ago
Comment on attachment 8593918 [details] [diff] [review]
Fix Register::GetName typedef issue with clang.

This fixes the issue. Thanks! :)
Attachment #8593918 - Flags: feedback?(gary) → feedback+
Attachment #8593918 - Flags: review?(jdemooij) → review+
(Reporter)

Updated

4 years ago
Target Milestone: --- → mozilla40
https://hg.mozilla.org/mozilla-central/rev/cb25e0475da5
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.