WebGL2 - Implement Queries

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kamidphish, Assigned: kamidphish)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Assignee: nobody → dglastonbury
Status: NEW → ASSIGNED
Whiteboard: [gfx-noted]
Created attachment 8593724 [details] [diff] [review]
Fix queries.

es3fTransformFeedbackTests exposed problems with queries. Queries are needed
to get the number of transformed primitives.
Attachment #8593724 - Flags: review?(jgilbert)
Comment on attachment 8593724 [details] [diff] [review]
Fix queries.

Review of attachment 8593724 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGL2ContextQueries.cpp
@@ +23,5 @@
>  static const char*
>  GetQueryTargetEnumString(GLenum target)
>  {
>      switch (target)
>      {

Can we switch this to `switch (foo) {` while we're at it?

@@ +67,5 @@
> +        return mActiveOcclusionQuery;
> +        
> +    case LOCAL_GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN:
> +        return mActiveTransformFeedbackQuery;
> +        

Whitespace!
Attachment #8593724 - Flags: review?(jgilbert) → review+
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Can we switch this to `switch (foo) {` while we're at it?

of course.

> Whitespace!

Ooops. (Blames Visual Studio)
https://hg.mozilla.org/mozilla-central/rev/f67a0b282680
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.