1155480 - Remove the padding right to Inspector pane toggle

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

There is quite a bit of right padding between the Inspector pane toggle button and the splitter. Let's remove it!

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1155480.patch

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Screenshot without Right Padding

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8593701 [details] [diff] [review]
1155480.patch

Removing the padding-right from #inspector-toolbar - there is still 3px padding right being applied by the .devtools-toolbar. I am tempted to still play around with padding. What are your thoughts on the style change?

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8593701 [details] [diff] [review]
1155480.patch

Review of attachment 8593701 [details] [diff] [review]:
-----------------------------------------------------------------

Those changes look fine to me, and the screenshot too. I don't have any strong feelings about this anyway.
You might want to check with Brian and with Stephen's mockups if we have any. But as far as code is concerned: r=me.

Comment 5

[Stephen Horlander [:shorlander]]

Comment on attachment 8593701 [details] [diff] [review]
1155480.patch

Review of attachment 8593701 [details] [diff] [review]:
-----------------------------------------------------------------

Looks much better. Thanks!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/347f037a8f11

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/347f037a8f11