Closed Bug 1155480 Opened 6 years ago Closed 6 years ago

Remove the padding right to Inspector pane toggle

Categories

(DevTools :: Inspector, defect)

defect
Not set
normal

Tracking

(firefox40 fixed)

RESOLVED FIXED
Firefox 40
Tracking Status
firefox40 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(2 files)

There is quite a bit of right padding between the Inspector pane toggle button and the splitter. Let's remove it!
Attached patch 1155480.patchSplinter Review
Assignee: nobody → gabriel.luong
Status: NEW → ASSIGNED
Attachment #8593704 - Attachment description: Screenshot → Screenshot without Right Padding
Comment on attachment 8593701 [details] [diff] [review]
1155480.patch

Removing the padding-right from #inspector-toolbar - there is still 3px padding right being applied by the .devtools-toolbar. I am tempted to still play around with padding. What are your thoughts on the style change?
Attachment #8593701 - Flags: review?(pbrosset)
Comment on attachment 8593701 [details] [diff] [review]
1155480.patch

Review of attachment 8593701 [details] [diff] [review]:
-----------------------------------------------------------------

Those changes look fine to me, and the screenshot too. I don't have any strong feelings about this anyway.
You might want to check with Brian and with Stephen's mockups if we have any. But as far as code is concerned: r=me.
Attachment #8593701 - Flags: review?(pbrosset) → review+
Attachment #8593701 - Flags: ui-review?(shorlander)
Attachment #8593701 - Flags: ui-review?(shorlander)
Attachment #8593701 - Flags: ui-review?(shorlander)
Comment on attachment 8593701 [details] [diff] [review]
1155480.patch

Review of attachment 8593701 [details] [diff] [review]:
-----------------------------------------------------------------

Looks much better. Thanks!
Attachment #8593701 - Flags: ui-review?(shorlander) → ui-review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/347f037a8f11
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.