1155501 - Context menu separator lines missing in 38.0 beta

Status: RESOLVED WORKSFORME

(Thunderbird :: Theme, defect)

Description

[Andrew Janke]

Attachment: missing lines - 38.0 beta.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150320202338

Steps to reproduce:

Start up Thunderbird Beta with at least one mail account defined in it. Right-click on any item in the account display pane on the left, or the list of email messages. Look at the context menu that pops up.


Actual results:

In the context menus that appear, the separators in the menus are just blank space, with no horizontal line drawn in them.

This applies only to context menus. The main menus in the OS X menu bar have separators as normal. (Perhaps because these are native widgets instead of XUL widgets?)

This is the 38.0b1 Beta on OS X 10.10.3. The current 31.6.0 release does not have this problem for me.



Expected results:

Separators in context menus should have horizontal lines drawn in the space they occupy, like in system menus.

Comment 1

[Andrew Janke]

Attachment: 31.6.0 showing the same menu, with lines present

Comment 2

[Wayne Mery (:wsmwk)]

in safe mode also?

Comment 3

[Andrew Janke]

Happens for me in safe mode, too: no lines drawn for the separators.

Comment 4

[Andrew Janke]

Looks like this is already fixed in 39 Earlybird: I see separators there when running it on the same machine. Maybe it'd be an easy back-port?

Comment 5

[Wayne Mery (:wsmwk)]

perhaps a theme issue?

Comment 6

[Kent James (:rkent)]

I downloaded Thunderbird 38 beta 3 and tested this, and I could not confirm the problem. Not sure it it was fixed, or if it is dependent on the local system, but without confirmation this is not a good candidate to be a TB 38 blocker. So I will remove tracking, feel free to add it back if more info is gathered.

Comment 7

[Josiah Bruner [:jsbruner]]

Needinfoing myself to look at this later.

Comment 8

[Josiah Bruner [:jsbruner]]

I don't see this on Yosemite. Janke, please provide as many details as possible on about your setup. Multiple displays? Resolution? HiDPI? Laptop? iMac? Any themes? Have you modified UserChrome.css? Etc.

Comment 9

[Andrew Janke]

I have two MacBook Pro laptops I've tested this on; call them mbp-ret and mbp-hires. On each, I'm dual-booting OS X 10.9.5 Mavericks (main) and OS X 10.10.3 Yosemite (secondary), and have other OSes running as VMs in VMware Fusion under the main 10.9 OS X.

mbp-ret: 
15" Retina MacBook Pro, Mid 2012; MacBookPro10,1, Model A1398
2.3 GHz i7-3615QM, 16 GB DDR3-1600 RAM, 768 GB SSD
Intel HD Graphics 4000 1GB integrated graphics
NVIDIA GeForce GT 650M discrete graphics

mbp-hires:
15" MacBook Pro, Mid 2010; MacBook Pro 6,2, Model A1286 (2nd gen) (EMC 2353)
Has the "high resolution" display option (1680x1050 WSXGA+)
2.66 GHz i7-620M, 8 GB RAM, 1 TB Crucial SSD
Intel HD Graphics, 256 MB shared integrated graphics
NVIDIA GeForce GT 330M 512 MB discrete graphics

I'm running both at their native resolutions: Retina/HiDPI 2880x1800 for mbp-ret, 1680x1050 for mbp-hires.
No external displays; I'm just using the built-in laptop display on each of them.

No themes.
I haven't modified UserChrome.css that I'm aware of.
This is a pretty stock installation: my 10.10 systems are just for testing, where 10.9 is my daily driver. 

I am also running F.lux. Still happens with F.lux turned off (exited entirely, not just disabled).

I retested this on mbp-hires on 10.10 with 38.0b1 and 38.0b2. (I don't see 38.0b3 on the downloads page yet.) I installed gfxCardStatus to test it under both discrete and integrated graphics. Happens the same under "discrete only", "integrated only", and "dynamic switching". (Though gfxCardStatus seems to be messing with things: when I have it running, Firefox windows in the background don't repaint when I drag the foreground window across them.)

Still happens if I lower the resolution on mbp-hires to 1024x640 or 1280x800.

Anything else that would be relevant? "As many details as possible" would be quite a bit. E.g. I could attach the System Report output for these machines or a diagnostic dump from Thunderbird if it produces those.

Comment 10

[Andrew Janke]

I found Thunderbird 38.0b3 at http://ftp.mozilla.org/pub/mozilla.org/thunderbird/releases/ and downloaded it. Still no separators for me on mbp-hires on 10.10.

(I was looking at https://www.mozilla.org/en-US/thunderbird/all-beta.html and https://www.mozilla.org/en-US/thunderbird/channel/ earlier, which are still showing 38.0b2 as of right now.)

Anything else I can do to help make this more reproducible?

Comment 11

[Wayne Mery (:wsmwk)]

Does it happen with all the betas, 32-37, at http://download.cdn.mozilla.net/pub/mozilla.org/thunderbird/releases/

Comment 12

[Andrew Janke]

Nope, not for me. Retested just now on mbp-hires, my OS X 10.10.3 non-retina MacBook, using builds from that link.

32.0b1 - ok
33.0b1 - ok
34.0b1 - ok
36.0b1 - ok
37.0b1 - ok
38.0b1 - missing separator line
38.0b2 - missing separator line
38.0b3 - missing separator line
38.0b6 - missing separator line

"missing separator line" = behavior this bug is complaining about. "ok" = separator line is drawn.

The prior major version betas look okay. And their context menus don't look quote "Yosemite-ish", either. (I.e. the background color differs, and something else feels off.) Seems like a change with theming or whatever for 38.

Comment 13

[Andrew Janke]

Attachment: missing lines - 38.0 beta.png

Comment 14

[Andrew Janke]

(I replaced the down-sampled retina image with an unaltered non-retina screenshot for the "missing lines" screenshot.)

Comment 15

[Javi Rueda :javirid]

Tested on Thunderbird 38.0.1 on OS X 10.10.4. Lines are shown as expected.

Could you re-test, janke? It should be on the release channel right now. Thank you.

Comment 16

[Andrew Janke]

Re-tested just now on mbp-hires, with Thunderbird 38.0.1 from the release channel on OS X 10.10.3. Separator lines are not drawn for me.

Upgraded to OS X 10.10.4. Separator lines are still not drawn for me.

Is there any additional system or diagnostic info I can provide to help track this down?

Comment 17

[Leo]

I confirm this issue: 

Mac OS X 10.10.4, iMac (27-inch, Mid 2011), Thunderbird 38.1.0.

I was afraid it's intentional - good to know it's a bug.

Comment 18

[Wayne Mery (:wsmwk)]

Still happening with current version started in safe mode?
 https://support.mozilla.org/en-US/kb/safe-mode

Comment 19

[Andrew Janke]

Still happening in production 38.4.0 in regular and safe mode.
Appears fixed in Thunderbird beta 42.0b2.

Comment 20

[Wayne Mery (:wsmwk)]

Thanks for testing the beta. 
We should expect to see this fixed then in version 45