Closed Bug 1155508 Opened 9 years ago Closed 9 years ago

Fix remaining dialer jshint issues

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

[gaia] KevinGrandon:bug_1155508_dialer_jshint > mozilla-b2g:master
46 bytes, text/x-github-pull-request
etienne
: review+
Details | Review 
We're getting close to being done with jshint fixes and can kill off some legacy code once we do so. Let's push this through!
Comment on attachment 8593749 [details] [review]
[gaia] KevinGrandon:bug_1155508_dialer_jshint > mozilla-b2g:master

Etienne - Mind giving me a quick review here? Thanks!
Attachment #8593749 - Flags: review?(etienne)
Attachment #8593749 - Flags: review?(etienne) → review+
+1 thanks for cleaning up the dialer
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/pull/29559

Autolander could not land the pull request due to not having collaborator rights. This is possibly due to a tree closure. Please check the tree status and request checkin again once the tree is open.
Weird, tree is reopened now - let's try this again.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: