1155524 - terraform should be able to make launch config changes

Status: RESOLVED FIXED

(Socorro :: Infra, task)

Description

[Robert Helmer [:rhelmer]]

As of Terraform 0.4, there is now a way to create a new launch config, attach it to the ASG, and destroy the old one - previously (when our configs were written) Terraform would error out trying to handle this in "terraform apply" since it'd create a duplicate-named LC which would fail.

I found out in IRC how people are doing this:

* the launch config must not have a name
* lifecycle { create_before_destroy } must be specified on the launch config

This option is documented at https://www.terraform.io/docs/configuration/resources.html

Comment 1

[JP Schneider [:jp]]

Attachment: 61365845.jpg

I've taken the additional proactive step of creating an informative bit of reminder documentation to not name our launch configs.

Comment 2

[Daniel Maher [:phrawzty]]

This bug has been open for a little while now, and tbh, I'm not clear on the parameters for resolution at this point.  Is this bug suggesting that we remove the names of all of the launch configs (since they all already have create_before_destroy)?  Is this bug still relevant, even?

Comment 3

[Robert Helmer [:rhelmer]]

This was fixed in https://github.com/mozilla/socorro-infra/commit/3bcda8124e6871160e6e165e888e9be7a2a95960