1155538 - [ja] Update the logo of google-jp searchplugin for Thunderbird

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Masahiko Imanaka [:marsf]]

Attachment: google-jp.xml for Tb

The google-jp logo for Thunderbird is not updated so far.
We have to update it to current one.
This is same data with Firefox.

Comment 1

[Magnus Melin [:mkmelin]]

Please don't forget to ask for review for patches
https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree#Getting_the_patch_reviewed

However, there's no mail/searchplugins/google-jp.xml in the source tree, not even a mail/searchplugins directory.

Comment 2

[Masahiko Imanaka [:marsf]]

Comment on attachment 8593778 [details] [diff] [review]
google-jp.xml for Tb

[Approval Request Comment]
Regression caused by (bug #): none.
User impact if declined: very low.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): none.
String changes made by this patch: ja locale specific.

This change is for using same current logo with Firefox.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/file/c2ec6d14646b/browser/searchplugins/google-jp.xml

Comment 3

[Masahiko Imanaka [:marsf]]

(In reply to Magnus Melin from comment #1)
> However, there's no mail/searchplugins/google-jp.xml in the source tree, not
> even a mail/searchplugins directory.

This is ja locale specific patch.
It doesn't affect to en-US or other locales.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/file/c2ec6d14646b/mail/searchplugins

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8593778 [details] [diff] [review]
google-jp.xml for Tb

Review of attachment 8593778 [details] [diff] [review]:
-----------------------------------------------------------------

Ok. This should be up to the [ja] locailzation team to decide, I think.

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8593778 [details] [diff] [review]
google-jp.xml for Tb

You need to ask for review, and set a reviewer.

Approval flags are for en-US patches, not for localization. That will go through sign-offs on the l10n dashboard.

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 8593778 [details] [diff] [review]
google-jp.xml for Tb

Review of attachment 8593778 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=philipp

Comment 7

[Masahiko Imanaka [:marsf]]

aurora (ja/ja-JP-mac):
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/bf78fd15a4bc
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/ebd85e61189a

beta (ja/ja-JP-mac):
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/51bb64d8267f
http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/b129d03922d2

Thank you very much.

Comment 8

[Masahiko Imanaka [:marsf]]

http://hg.mozilla.org/l10n-central/ja/rev/81394d85b6e8
http://hg.mozilla.org/l10n-central/ja-JP-mac/rev/d7b2a462533a