Closed
Bug 1155538
Opened 9 years ago
Closed 9 years ago
[ja] Update the logo of google-jp searchplugin for Thunderbird
Categories
(Mozilla Localizations :: ja / Japanese, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: marsf, Assigned: marsf)
Details
Attachments
(1 file)
4.21 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
The google-jp logo for Thunderbird is not updated so far. We have to update it to current one. This is same data with Firefox.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → chimantaea_mirabilis
Comment 1•9 years ago
|
||
Please don't forget to ask for review for patches https://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree#Getting_the_patch_reviewed However, there's no mail/searchplugins/google-jp.xml in the source tree, not even a mail/searchplugins directory.
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8593778 [details] [diff] [review] google-jp.xml for Tb [Approval Request Comment] Regression caused by (bug #): none. User impact if declined: very low. Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): none. String changes made by this patch: ja locale specific. This change is for using same current logo with Firefox. http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/file/c2ec6d14646b/browser/searchplugins/google-jp.xml
Attachment #8593778 -
Flags: review?(mkmelin+mozilla)
Attachment #8593778 -
Flags: approval-comm-beta?
Attachment #8593778 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Magnus Melin from comment #1) > However, there's no mail/searchplugins/google-jp.xml in the source tree, not > even a mail/searchplugins directory. This is ja locale specific patch. It doesn't affect to en-US or other locales. http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/file/c2ec6d14646b/mail/searchplugins
Comment 4•9 years ago
|
||
Comment on attachment 8593778 [details] [diff] [review] google-jp.xml for Tb Review of attachment 8593778 [details] [diff] [review]: ----------------------------------------------------------------- Ok. This should be up to the [ja] locailzation team to decide, I think.
Attachment #8593778 -
Flags: review?(mkmelin+mozilla)
Attachment #8593778 -
Flags: approval-comm-beta?
Attachment #8593778 -
Flags: approval-comm-aurora?
Comment 5•9 years ago
|
||
Comment on attachment 8593778 [details] [diff] [review] google-jp.xml for Tb You need to ask for review, and set a reviewer. Approval flags are for en-US patches, not for localization. That will go through sign-offs on the l10n dashboard.
Attachment #8593778 -
Flags: review?(philipp)
Comment 6•9 years ago
|
||
Comment on attachment 8593778 [details] [diff] [review] google-jp.xml for Tb Review of attachment 8593778 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=philipp
Attachment #8593778 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 7•9 years ago
|
||
aurora (ja/ja-JP-mac): http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/bf78fd15a4bc http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/ebd85e61189a beta (ja/ja-JP-mac): http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/51bb64d8267f http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/b129d03922d2 Thank you very much.
Assignee | ||
Comment 8•9 years ago
|
||
http://hg.mozilla.org/l10n-central/ja/rev/81394d85b6e8 http://hg.mozilla.org/l10n-central/ja-JP-mac/rev/d7b2a462533a
Assignee | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•